Lars/mitai-jinkendo
1
0
Fork 0
Code Issues 33 Pull Requests Actions Packages Projects Releases 5 Wiki Activity
0d0ab62674
mitai-jinkendo/frontend/src/components
History
Lars 3b4902dc11
All checks were successful
Deploy Development / deploy (push) Successful in 47s
Details
Build Test / lint-backend (push) Successful in 0s
Details
Build Test / build-frontend (push) Successful in 15s
Details
fix: CRITICAL - Use question ID in placeholders, not type 
Root Cause:
- Multiple questions with same type (e.g. "unsicherheit") created duplicate placeholders
- {{ node_4.signal_unsicherheit }} could refer to q21 OR q22
- Later signal overwrote earlier one in template context

Solution:
- Placeholders now use question ID: {{ node_4.signal_q21 }}
- Unique even with multiple questions of same type

Frontend PlaceholderPicker.jsx:
- Changed placeholder: signal_${questionType} → signal_${questionId}
- Changed placeholder: question_${questionType} → question_${questionId}
- Description shows both: "q21 (unsicherheit): Question text"

Backend workflow_executor.py:
- Build question_type → question_id mapping from graph
- Map normalized_signals (by type) to question IDs
- Handles duplicate types with index tracking
- Creates signal_${id} and question_${id} in template context

Example:
Questions configured:
- q21: type="unsicherheit", question="Ist Protein unsicher?"
- q22: type="unsicherheit", question="Ist Energie unsicher?"

Placeholders generated:
- {{ node_4.signal_q21 }} → "nein"
- {{ node_4.signal_q22 }} → "ja"
- {{ node_4.question_q21 }} → "Ist Protein unsicher?"
- {{ node_4.question_q22 }} → "Ist Energie unsicher?"

Issue: Duplicate question types cause placeholder conflicts
Version: 0.9p (workflow module)
Part 3: End Node Template Engine - CRITICAL FIX

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-09 21:01:24 +02:00
..
dashboard-widgets feat: Add new widgets and enhance configuration validation 2026-04-07 20:58:44 +02:00
pilot feat: Introduce quick capture widget configuration and validation 2026-04-07 18:02:18 +02:00
workflow fix: CRITICAL - Use question ID in placeholders, not type 2026-04-09 21:01:24 +02:00
BulkCategorize.jsx feat: automatic training type mapping for Apple Health import and bulk categorization 2026-03-21 15:08:18 +01:00
DashboardSection.jsx feat: Refactor dashboard layout with new DashboardSection and DashboardTile components for improved responsiveness and organization 2026-04-05 08:42:07 +02:00
DashboardStatKit.jsx feat: Enhance dashboard widget configuration and introduce new widgets 2026-04-07 14:19:45 +02:00
DashboardTile.jsx feat: Refactor dashboard layout with new DashboardSection and DashboardTile components for improved responsiveness and organization 2026-04-05 08:42:07 +02:00
DesktopSidebar.jsx feat: Implement CaptureShell layout with sub-navigation for capture section 2026-04-05 10:17:47 +02:00
EmailSettings.jsx feat: Refactor admin settings and user management 2026-04-05 10:32:43 +02:00
EmailVerificationBanner.jsx feat: resend verification email functionality 2026-03-21 10:23:38 +01:00
EmojiIconPicker.jsx feat: Enhance EmojiIconPicker with search functionality and keyword support 2026-04-04 14:22:44 +02:00
emojiIconPickerKeywords.js feat: Enhance EmojiIconPicker with search functionality and keyword support 2026-04-04 14:22:44 +02:00
FeatureUsageOverview.css feat: add feature usage UI components (Phase 3) 2026-03-21 06:39:52 +01:00
FeatureUsageOverview.jsx feat: add feature usage UI components (Phase 3) 2026-03-21 06:39:52 +01:00
NutritionCharts.jsx feat: Konzept-konforme Nutrition Charts (E1-E5 komplett) 2026-03-29 07:28:56 +02:00
PlaceholderPicker.jsx feat: Analysis page pipeline-only + wider placeholder examples (Issue #28) 2026-03-26 07:50:13 +01:00
ProfileBuilder.jsx docs: update ProfileBuilder placeholder for future dimensions 2026-03-23 14:40:56 +01:00
PromptGenerator.jsx fix: prompt editor layout - full-width inputs, left-aligned text (Issue #28) 2026-03-24 20:53:15 +01:00
QuickWeightEntry.jsx feat: Enhance dashboard widget configuration and introduce new widgets 2026-04-07 14:19:45 +02:00
RecoveryCharts.jsx feat: Phase 0c Frontend Phase 1 - Nutrition + Recovery Charts 2026-03-29 07:02:54 +02:00
RestDaysWidget.jsx feat: dashboard rest days widget + today highlighting 2026-03-23 08:38:57 +01:00
SleepWidget.jsx feat: add missing migration 008 (vitals, rest days, sleep_goal_minutes) 2026-03-22 10:59:55 +01:00
TrainingTypeDistribution.jsx feat: Enhance activity API feat: Enhance sleep data import functionality with support for multiple CSV formats and improved data parsing 2026-04-07 12:28:59 +02:00
TrainingTypeSelect.jsx feat(v9d): add training types system + logout button 2026-03-21 13:05:33 +01:00
TrendKcalWeightChart.jsx feat: Enhance dashboard widget configuration and introduce new widgets 2026-04-07 14:19:45 +02:00
TrialBanner.jsx fix: change trial banner button to mailto contact link 2026-03-21 12:52:13 +01:00
UnifiedPromptModal.jsx fix: value table metadata + |d modifier + cursor insertion (Issues #47, #48) 2026-03-26 12:04:20 +01:00
UsageBadge.css refactor: consolidate badge styling to CSS classes 2026-03-21 06:54:45 +01:00
UsageBadge.jsx feat: add feature usage UI components (Phase 3) 2026-03-21 06:39:52 +01:00