Files
tsumugu/backend/tests/test_room_roles.py
T
LarsandClaude Sonnet 5.5 037c0724a8
Deploy Development / deploy (push) Successful in 42s
Test Suite / pytest-backend (push) Successful in 3m28s
Test Suite / smoke-dev (push) Successful in 0s
Test Suite / frontend-build (push) Successful in 20s
Ergänze die Benutzerverwaltung, damit der Betreiber Konten, Rollen und Zugänge verwalten kann.
Der Betreiber legt Konten mit Einmal-Passwort an, deaktiviert und aktiviert sie, setzt Passwörter zurück, beendet Sitzungen und vergibt die Betreiberrolle; der letzte Betreiber und das eigene Konto sind geschützt. Nutzer ändern ihr Passwort und sehen ihre Geräte. Räume kennen neben Mitglied und Verwalter die Rolle Leser, die nichts anlegt und keine Bearbeiten- oder Freigeben-Grants erhält. Verwalter pflegen Mitglieder, Rollen und Einladungen mit Rolle; der Betreiber sieht Räume ohne Inhalte und liest das Verwaltungsprotokoll. Die Login-Begrenzung steht in der Datenbank, unbekannte Konten laufen durch einen Zeitausgleich.

Die lokale Suite läuft mit 116 Tests grün, der Frontend-Build und 16 Node-Tests ebenfalls. Die Oberfläche wurde noch nicht im Browser bedient.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-20 12:49:23 +02:00

211 lines
11 KiB
Python

"""Datenraumrollen (Mitglied, Verwalter, Leser), Einladungen, Betreiberübersicht."""
from __future__ import annotations
from fastapi.testclient import TestClient
from tests.support import ORIGIN, PASSWORD, Actor, register
def _second_client():
from app.main import app
return TestClient(app)
def _setup(client, db):
ada = Actor(client, "ada-rolle@example.test", "Ada Rolle")
ben = Actor(_second_client(), "ben-rolle@example.test", "Ben Rolle")
cem = Actor(_second_client(), "cem-rolle@example.test", "Cem Rolle")
for actor in (ada, ben, cem):
register(db, actor.email, actor.name)
actor.login()
room = ada.request("POST", "/api/v1/rooms", json={"name": "Verein"}, status=201)
ada.use_room(room["id"])
return ada, ben, cem, room["id"]
def test_manager_sets_roles_and_a_reader_creates_nothing(client, db):
ada, ben, cem, room = _setup(client, db)
ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": ben.email, "role": "reader"})
ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": cem.email, "role": "member"})
members = {item["email"]: item["role"] for item in ada.request("GET", f"/api/v1/rooms/{room}/members")["items"]}
assert members == {ada.email: "manager", ben.email: "reader", cem.email: "member"}
ben.use_room(room)
cem.use_room(room)
refused = ben.request("POST", "/api/v1/cases", json={"title": "Nicht erlaubt"}, status=403)
assert "Leser" in refused["detail"]
ben.request("POST", "/api/v1/matters", json={"title": "Auch nicht"}, status=403)
cem.request("POST", "/api/v1/cases", json={"title": "Erlaubt"}, status=201)
# The role is read from the database at every request.
ada.request("PATCH", f"/api/v1/rooms/{room}/members/{_subject(ada, room, ben.email)}", json={"role": "member"})
ben.request("POST", "/api/v1/cases", json={"title": "Jetzt erlaubt"}, status=201)
ada.request("PATCH", f"/api/v1/rooms/{room}/members/{_subject(ada, room, ben.email)}", json={"role": "reader"})
ben.request("POST", "/api/v1/cases", json={"title": "Wieder nicht"}, status=403)
def test_a_reader_gets_no_edit_grant_and_loses_existing_ones(client, db):
ada, ben, cem, room = _setup(client, db)
ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": ben.email, "role": "member"})
ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": cem.email, "role": "reader"})
case = ada.request("POST", "/api/v1/cases", json={"title": "Gemeinsam"}, status=201)
refused = ada.request(
"POST",
f"/api/v1/cases/{case['id']}/grants",
json={"email": cem.email, "can_read": True, "can_edit": True, "can_share": False},
status=422,
)
assert "Leser" in refused["detail"]
ada.request(
"POST",
f"/api/v1/cases/{case['id']}/grants",
json={"email": cem.email, "can_read": True, "can_edit": False, "can_share": False},
status=201,
)
ada.request(
"POST",
f"/api/v1/cases/{case['id']}/grants",
json={"email": ben.email, "can_read": True, "can_edit": True, "can_share": True},
status=201,
)
ada.request("PATCH", f"/api/v1/rooms/{room}/members/{_subject(ada, room, ben.email)}", json={"role": "reader"})
grant = db.execute(
"SELECT can_read, can_edit, can_share FROM access_grants WHERE grantee_subject_id = (SELECT id FROM auth_accounts WHERE email = %s)",
(ben.email,),
).fetchone()
db.rollback()
assert grant == {"can_read": True, "can_edit": False, "can_share": False}
def test_the_last_manager_stays(client, db):
ada, ben, _cem, room = _setup(client, db)
me = _subject(ada, room, ada.email)
ada.request("PATCH", f"/api/v1/rooms/{room}/members/{me}", json={"role": "member"}, status=422)
ada.request("DELETE", f"/api/v1/rooms/{room}/members/{me}", status=422)
ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": ada.email, "role": "reader"}, status=422)
ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": ben.email, "role": "manager"})
ada.request("PATCH", f"/api/v1/rooms/{room}/members/{me}", json={"role": "member"})
# Ben is the only manager now.
ben.use_room(room)
ben.request("DELETE", f"/api/v1/rooms/{room}/members/{_subject(ben, room, ben.email)}", status=422)
ada.request("GET", f"/api/v1/rooms/{room}/members", status=403)
def test_a_removed_member_loses_the_room_at_once(client, db):
ada, ben, _cem, room = _setup(client, db)
ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": ben.email, "role": "member"})
ben.use_room(room)
ben.request("GET", "/api/v1/cases")
ada.request("DELETE", f"/api/v1/rooms/{room}/members/{_subject(ada, room, ben.email)}", status=204)
ben.request("GET", "/api/v1/cases", status=403)
def test_invitations_carry_a_role_and_can_be_revoked(client, db):
ada, ben, _cem, room = _setup(client, db)
invited = ada.request(
"POST",
"/api/v1/invitations",
json={"email": "neu-rolle@example.test", "room_id": room, "role": "reader"},
status=201,
)
assert invited["role"] == "reader" and invited["token"]
ada.request("POST", "/api/v1/invitations", json={"email": ben.email, "room_id": room}, status=422)
open_items = ada.request("GET", f"/api/v1/rooms/{room}/invitations")["items"]
assert [item["email"] for item in open_items] == ["neu-rolle@example.test"]
assert "token" not in open_items[0]
ben.request("GET", f"/api/v1/rooms/{room}/invitations", status=403)
guest = _second_client()
accepted = guest.post(
f"/api/v1/invitations/{invited['id']}/accept",
json={"token": invited["token"], "display_name": "Neu Gast", "password": PASSWORD},
headers={"Origin": ORIGIN},
)
assert accepted.status_code == 201, accepted.text
assert [(r["name"], r["role"]) for r in accepted.json()["rooms"] if r["kind"] == "organization"] == [("Verein", "reader")]
again = _second_client().post(
f"/api/v1/invitations/{invited['id']}/accept",
json={"token": invited["token"], "display_name": "Zweiter", "password": PASSWORD},
headers={"Origin": ORIGIN},
)
assert again.status_code == 404
second = ada.request("POST", "/api/v1/invitations", json={"email": "widerruf@example.test", "room_id": room}, status=201)
ada.request("DELETE", f"/api/v1/rooms/{room}/invitations/{second['id']}", status=204)
refused = _second_client().post(
f"/api/v1/invitations/{second['id']}/accept",
json={"token": second["token"], "display_name": "Widerruf", "password": PASSWORD},
headers={"Origin": ORIGIN},
)
assert refused.status_code == 404
ada.request("DELETE", f"/api/v1/rooms/{room}/invitations/{second['id']}", status=404)
def test_rooms_are_renamed_archived_and_restored_by_a_manager(client, db):
ada, ben, _cem, room = _setup(client, db)
ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": ben.email, "role": "member"})
ben.request("PATCH", f"/api/v1/rooms/{room}", json={"name": "Fremd"}, status=403)
renamed = ada.request("PATCH", f"/api/v1/rooms/{room}", json={"name": "Verein e.V."})
assert renamed["name"] == "Verein e.V."
ada.request("PATCH", f"/api/v1/rooms/{room}", json={"status": "archived"})
# The session of the archiving manager moved back to the personal room.
ada.request("GET", "/api/v1/rooms", status=403)
body = ada.request("GET", "/api/v1/auth/session")
assert body["scope"]["kind"] == "personal"
ada.scope, ada.csrf = body["scope"], body["csrf_token"]
listed = ada.request("GET", "/api/v1/rooms", params={"include_archived": "true"})["items"]
assert any(item["id"] == room and item.get("status") == "archived" for item in listed)
ada.request("POST", "/api/v1/auth/session/scope", json={"kind": "organization", "id": room}, status=403)
ada.request("PATCH", f"/api/v1/rooms/{room}", json={"status": "active"})
ada.use_room(room)
def test_operator_sees_rooms_without_content_and_fills_an_orphaned_room(client, db):
ada, ben, _cem, room = _setup(client, db)
operator = Actor(_second_client(), "betreiber-rolle@example.test", "Betreiber Rolle")
register(db, operator.email, operator.name, superadmin=True)
operator.login()
ada.request("POST", "/api/v1/cases", json={"title": "Nur für Ada"}, status=201)
overview = operator.request("GET", "/api/v1/admin/rooms")["items"]
row = next(item for item in overview if item["id"] == room)
assert row["managers"] == ["Ada Rolle"] and row["members"] == 1 and row["has_manager"] is True
assert "Nur für Ada" not in str(overview)
operator.request("GET", f"/api/v1/rooms/{room}/members", status=403)
ben.request("GET", "/api/v1/admin/rooms", status=403)
operator.request("POST", f"/api/v1/admin/rooms/{room}/managers", json={"email": ben.email}, status=403)
db.execute("UPDATE auth_accounts SET status = 'disabled' WHERE email = %s", (ada.email,))
db.commit()
assigned = operator.request("POST", f"/api/v1/admin/rooms/{room}/managers", json={"email": ben.email})
assert assigned["role"] == "manager"
ben.use_room(room)
assert {item["email"] for item in ben.request("GET", f"/api/v1/rooms/{room}/members")["items"]} >= {ben.email}
def test_room_events_reach_the_operator_audit_without_secrets(client, db):
ada, ben, _cem, room = _setup(client, db)
operator = Actor(_second_client(), "audit-rolle@example.test", "Audit Rolle")
register(db, operator.email, operator.name, superadmin=True)
operator.login()
ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": ben.email, "role": "reader"})
invited = ada.request("POST", "/api/v1/invitations", json={"email": "audit-gast@example.test", "room_id": room}, status=201)
events = operator.request("GET", "/api/v1/admin/events", params={"limit": 50})
actions = [item["action"] for item in events["items"]]
assert {"room_created", "membership_added", "invitation_created"} <= set(actions)
text = str(events)
assert "audit-gast@example.test" not in text and invited["token"] not in text
ben.request("GET", "/api/v1/admin/events", status=403)
page = operator.request("GET", "/api/v1/admin/events", params={"limit": 1})
assert len(page["items"]) == 1 and page["next_cursor"] == 1
def _subject(actor: Actor, room: str, email: str) -> str:
# A manager lists the members; Ada manages in these tests. Fall back to the account table.
from app.core.settings import get_settings
import psycopg
with psycopg.connect(get_settings().dsn(), row_factory=psycopg.rows.dict_row) as conn:
return str(conn.execute("SELECT id FROM auth_accounts WHERE email = %s", (email,)).fetchone()["id"])