Files
LarsandClaude Sonnet 5.5 6d7b7c5f85
Deploy Development / deploy (push) Successful in 45s
Test Suite / pytest-backend (push) Successful in 5m20s
Test Suite / smoke-dev (push) Successful in 0s
Test Suite / frontend-build (push) Successful in 21s
Führe Hauptnutzer und Mitarbeiter ein, damit der Betreiber Kunden und Hauptnutzer ihre Teams verwalten.
Eine Einladung erzeugt jetzt ein Mitarbeiter-Konto mit dem Eigentümer des Raums als Förderer. Mitarbeiter arbeiten nur in den eingeladenen Räumen nach ihrer Rolle, legen keine Räume und im persönlichen Raum nichts an und starten ihre Sitzung im Team-Raum. Einladen darf nur der Eigentümer als Hauptnutzer; nur ein Hauptnutzer kann Raum-Eigentümer sein. Hauptnutzer sehen unter Mein Team die Personen in ihren Räumen und verwalten ihre Mitarbeiter (deaktivieren, Einmal-Passwort, aus Räumen entfernen). Der Betreiber sieht die Team-Übersicht mit CSV-Export und macht einen Mitarbeiter zum Hauptnutzer.

Eine zentrale Prüfstelle für Grenzen (access/limits.py) wird beim Anlegen von Räumen und beim Aufnehmen und Einladen von Mitgliedern aufgerufen; Tarife folgen später.

Die lokale Suite läuft mit 143 Tests grün, der Frontend-Build und 24 Node-Tests ebenfalls. Die Oberfläche wurde noch nicht im Browser bedient.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-22 09:03:40 +02:00

221 lines
11 KiB
Python

"""Hauptnutzer, Mitarbeiter und Teamverwaltung."""
from __future__ import annotations
import uuid
import pytest
from fastapi.testclient import TestClient
from app.auth.accounts import create_account
from app.core.errors import unprocessable
from tests.support import ORIGIN, PASSWORD, Actor
def _second_client():
from app.main import app
return TestClient(app)
def _main(client, db, key: str, *, main: bool = False, superadmin: bool = False) -> Actor:
actor = Actor(client if main else _second_client(), f"{key}-team@example.test", key.title())
create_account(db, actor.email, actor.name, PASSWORD, is_superadmin=superadmin)
db.commit()
actor.login()
return actor
def _invite(owner: Actor, room: str, email: str, role: str = "member", name: str = "Mitarbeiter") -> Actor:
invited = owner.request("POST", "/api/v1/invitations", json={"email": email, "room_id": room, "role": role}, status=201)
client = _second_client()
response = client.post(
f"/api/v1/invitations/{invited['id']}/accept",
json={"token": invited["token"], "display_name": name, "password": PASSWORD},
headers={"Origin": ORIGIN},
)
assert response.status_code == 201, response.text
employee = Actor(client, email, name)
employee.login()
return employee
def _id(db, email: str) -> str:
row = db.execute("SELECT id FROM auth_accounts WHERE email = %s", (email,)).fetchone()
db.rollback()
return str(row["id"])
@pytest.fixture
def world(client, db):
ada = _main(client, db, "ada", main=True)
room = ada.request("POST", "/api/v1/rooms", json={"name": "Kanzlei"}, status=201)["id"]
ada.use_room(room)
employee = _invite(ada, room, "emp-team@example.test", name="Eva Mitarbeiterin")
return {"ada": ada, "room": room, "emp": employee}
def test_an_invitation_creates_an_employee_account_sponsored_by_the_owner(world, db):
row = db.execute("SELECT account_kind, sponsor_id FROM auth_accounts WHERE email = 'emp-team@example.test'").fetchone()
db.rollback()
assert row["account_kind"] == "employee"
assert str(row["sponsor_id"]) == _id(db, world["ada"].email)
assert world["emp"].request("GET", "/api/v1/auth/session")["account"]["account_kind"] == "employee"
assert world["ada"].request("GET", "/api/v1/auth/session")["account"]["account_kind"] == "main"
def test_an_employee_works_only_in_the_rooms_he_was_invited_to(world, db):
emp, room = world["emp"], world["room"]
emp.request("POST", "/api/v1/rooms", json={"name": "Eigener Raum"}, status=403)
# The session starts in the team room, not in a personal room.
assert emp.scope["kind"] == "organization" and emp.scope["id"] == room
# In the personal room nothing is created.
personal = emp.request("POST", "/api/v1/auth/session/scope", json={"kind": "personal", "id": _id(db, emp.email)})
emp.scope, emp.csrf = personal["scope"], personal["csrf_token"]
emp.request("POST", "/api/v1/cases", json={"title": "Privat"}, status=403)
emp.request("POST", "/api/v1/matters", json={"title": "Privat"}, status=403)
emp.use_room(room)
case = emp.request("POST", "/api/v1/cases", json={"title": "Im Team"}, status=201)
world["ada"].request("GET", f"/api/v1/cases/{case['id']}")
# Rights follow the role: a reader only reads.
world["ada"].request("PATCH", f"/api/v1/rooms/{room}/members/{_id(db, emp.email)}", json={"role": "reader"})
emp.request("POST", "/api/v1/cases", json={"title": "Nicht mehr"}, status=403)
emp.request("GET", f"/api/v1/cases/{case['id']}")
def test_only_the_owner_invites_and_an_employee_never_does(world, client, db):
ada, emp, room = world["ada"], world["emp"], world["room"]
ben = _main(client, db, "ben")
ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": ben.email, "role": "manager"})
ben.use_room(room)
# A manager who is not the owner adds existing accounts but creates no new ones.
ben.request("POST", "/api/v1/invitations", json={"email": "neu-team@example.test", "room_id": room}, status=403)
ben.request("POST", f"/api/v1/rooms/{room}/members", json={"email": emp.email, "role": "reader"})
emp.request("POST", "/api/v1/invitations", json={"email": "neu-team@example.test", "room_id": room}, status=403)
def test_an_employee_cannot_own_a_room(world, db):
ada, emp, room = world["ada"], world["emp"], world["room"]
ada.request("POST", f"/api/v1/rooms/{room}/owner", json={"subject_id": _id(db, emp.email)}, status=422)
operator = _main(world["ada"].client.__class__ and _second_client(), db, "betreiber", superadmin=True)
db.execute("UPDATE auth_accounts SET status = 'disabled' WHERE id = %s", (_id(db, ada.email),))
db.commit()
operator.request("POST", f"/api/v1/admin/rooms/{room}/owner", json={"email": emp.email}, status=422)
def test_my_team_lists_only_people_in_my_rooms_and_acts_only_on_my_employees(world, client, db):
ada, emp = world["ada"], world["emp"]
cara = _main(client, db, "cara")
emp_id = _id(db, emp.email)
listed = ada.request("GET", "/api/v1/team")["items"]
assert [(p["email"], p["mine"], p["rooms"][0]["role"]) for p in listed] == [(emp.email, True, "member")]
assert cara.request("GET", "/api/v1/team")["items"] == []
emp.request("GET", "/api/v1/team", status=403)
unknown = str(uuid.uuid4())
for actor in (cara,):
foreign = actor.request("PATCH", f"/api/v1/team/{emp_id}", json={"status": "disabled"}, status=403)
missing = actor.request("PATCH", f"/api/v1/team/{unknown}", json={"status": "disabled"}, status=403)
assert foreign["detail"] == missing["detail"]
actor.request("POST", f"/api/v1/team/{emp_id}/password-reset", status=403)
actor.request("DELETE", f"/api/v1/team/{emp_id}/memberships", status=403)
# A main user is not a sponsored employee: no team action on him, not even by the owner.
cara_id = _id(db, cara.email)
ada.request("PATCH", f"/api/v1/team/{cara_id}", json={"status": "disabled"}, status=403)
ada.request("POST", f"/api/v1/team/{cara_id}/password-reset", status=403)
def test_the_owner_disables_resets_and_removes_an_employee(world, db):
ada, emp, room = world["ada"], world["emp"], world["room"]
emp_id = _id(db, emp.email)
ada.request("PATCH", f"/api/v1/team/{emp_id}", json={"status": "disabled"})
emp.request("GET", "/api/v1/auth/session", status=401)
login = emp.client.post("/api/v1/auth/login", json={"email": emp.email, "password": PASSWORD}, headers={"Origin": ORIGIN})
assert login.status_code == 401
ada.request("PATCH", f"/api/v1/team/{emp_id}", json={"status": "active"})
reset = ada.request("POST", f"/api/v1/team/{emp_id}/password-reset")
emp.password = reset["temporary_password"]
assert emp.login()["account"]["must_change_password"] is True
emp.request("GET", "/api/v1/cases", status=403)
ada.request("DELETE", f"/api/v1/team/{emp_id}/memberships", status=204)
assert ada.request("GET", "/api/v1/team")["items"][0]["rooms"] == []
# Without a room the employee lands in the personal room, where he can do nothing but change his password.
assert emp.login()["scope"]["kind"] == "personal"
ada.request("DELETE", f"/api/v1/team/{emp_id}/memberships", status=403)
ada.request("DELETE", f"/api/v1/team/{_id(db, ada.email)}/memberships", status=403)
assert room
def test_the_operator_sees_the_teams_as_metadata_and_exports_them_safely(world, client, db):
ada, room = world["ada"], world["room"]
_invite(ada, room, "formel-team@example.test", role="reader", name="=SUM(1+1)")
operator = _main(_second_client(), db, "betreiber", superadmin=True)
note = ada.request("POST", "/api/v1/cases", json={"title": "Geheimer Inhalt"}, status=201)
overview = operator.request("GET", "/api/v1/admin/team")["items"]
owner = next(item for item in overview if item["email"] == ada.email)
assert {e["email"] for e in owner["employees"]} == {"emp-team@example.test", "formel-team@example.test"}
assert all(r["name"] == "Kanzlei" for e in owner["employees"] for r in e["rooms"])
assert "Geheimer Inhalt" not in str(overview) and note["title"] == "Geheimer Inhalt"
response = operator.client.get(
"/api/v1/admin/team",
params={"format": "csv"},
headers={"Origin": ORIGIN, "X-Scope-Kind": operator.scope["kind"], "X-Scope-Id": operator.scope["id"]},
)
assert response.status_code == 200 and response.headers["content-type"].startswith("text/csv")
lines = response.text.splitlines()
assert lines[0] == "Hauptnutzer,Mitarbeiter,E-Mail,Status,Datenraum,Rolle"
assert any("'=SUM(1+1)" in line for line in lines)
assert not any(line.split(",")[1].startswith("=") for line in lines[1:])
world["emp"].request("GET", "/api/v1/admin/team", status=403)
ada.request("GET", "/api/v1/admin/team", status=403)
def test_only_the_operator_promotes_an_employee(world, client, db):
ada, emp, room = world["ada"], world["emp"], world["room"]
emp_id = _id(db, emp.email)
ada.request("PATCH", f"/api/v1/accounts/{emp_id}", json={"account_kind": "main"}, status=403)
operator = _main(_second_client(), db, "betreiber", superadmin=True)
listed = {a["email"]: a for a in operator.request("GET", "/api/v1/accounts")["items"]}
assert listed[emp.email]["account_kind"] == "employee" and listed[emp.email]["sponsor_name"] == "Ada"
assert operator.request("GET", f"/api/v1/accounts/{_id(db, ada.email)}")["employees"][0]["email"] == emp.email
operator.request("PATCH", f"/api/v1/accounts/{emp_id}", json={"account_kind": "main"})
emp.request("GET", "/api/v1/cases", status=401)
fresh = Actor(emp.client, emp.email, emp.name)
assert fresh.login()["account"]["account_kind"] == "main"
fresh.request("POST", "/api/v1/rooms", json={"name": "Eigener Raum"}, status=201)
assert room
def test_limits_have_one_place_and_are_checked_where_they_matter(world, client, db, monkeypatch):
ada, room = world["ada"], world["room"]
seen = []
def block_room(conn, owner_id):
seen.append(("room", owner_id))
raise unprocessable("Grenze erreicht.")
def block_member(conn, owner_id, room_id):
seen.append(("member", owner_id, room_id))
raise unprocessable("Grenze erreicht.")
cem = _main(client, db, "cem")
monkeypatch.setattr("app.api.rooms.ensure_can_create_room", block_room)
ada.request("POST", "/api/v1/rooms", json={"name": "Noch ein Raum"}, status=422)
monkeypatch.setattr("app.api.rooms.ensure_can_add_member", block_member)
ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": cem.email, "role": "member"}, status=422)
ada.request("POST", "/api/v1/invitations", json={"email": "grenze-team@example.test", "room_id": room}, status=422)
assert [entry[0] for entry in seen] == ["room", "member", "member"]
assert all(entry[1] == uuid.UUID(_id(db, ada.email)) for entry in seen)
# Changing the role of an existing member needs no check.
monkeypatch.undo()
invited = ada.request("POST", "/api/v1/invitations", json={"email": "spaet-team@example.test", "room_id": room}, status=201)
monkeypatch.setattr("app.api.routes.ensure_can_add_member", block_member)
refused = _second_client().post(
f"/api/v1/invitations/{invited['id']}/accept",
json={"token": invited["token"], "display_name": "Spät", "password": PASSWORD},
headers={"Origin": ORIGIN},
)
assert refused.status_code == 422
assert db.execute("SELECT 1 FROM auth_accounts WHERE email = 'spaet-team@example.test'").fetchone() is None
db.rollback()