"""Bibliothek: Zähler nur aus Lesbarem, Rauminhalt, Raumübersicht und Teilen im Stapel.""" from __future__ import annotations import pytest from fastapi.testclient import TestClient from app.auth.accounts import create_account from tests.support import PASSWORD, Actor, matter_of def _second_client(): from app.main import app return TestClient(app) def _actor(client, db, key: str, *, main: bool = False) -> Actor: actor = Actor(client if main else _second_client(), f"{key}-bib@example.test", key.title()) create_account(db, actor.email, actor.name, PASSWORD) db.commit() actor.login() return actor @pytest.fixture def world(client, db): ada = _actor(client, db, "ada", main=True) ben = _actor(client, db, "ben") cem = _actor(client, db, "cem") dan = _actor(client, db, "dan") room = ada.request("POST", "/api/v1/rooms", json={"name": "Werkstatt", "default_visibility": "private"}, status=201)["id"] ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": ben.email, "role": "member"}) ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": cem.email, "role": "reader"}) return {"ada": ada, "ben": ben, "cem": cem, "dan": dan, "room": room} def _share(actor, plural, resource_id, room, status=200): return actor.request("PUT", f"/api/v1/{plural}/{resource_id}/room-share/rooms/{room}", json={"access": "edit"}, status=status) def _link(actor, matter, case): actor.request("POST", f"/api/v1/matters/{matter}/case-links", json={"case_id": case}, status=201) def test_counts_include_only_what_the_person_may_read(world): ada, ben, room = world["ada"], world["ben"], world["room"] case = ada.request("POST", "/api/v1/cases", json={"title": "Vermietung"}, status=201) child = ada.request( "POST", "/api/v1/cases", json={"title": "Nebenkosten", "parent_case_id": case["id"], "rights_mode": "inherit_parent"}, status=201, ) one = matter_of(ada, "Mietminderung") two = matter_of(ada, "Eigenbedarf intern") _link(ada, one["id"], case["id"]) _link(ada, two["id"], case["id"]) _share(ada, "cases", case["id"], room) mine = next(i for i in ada.request("GET", "/api/v1/cases")["items"] if i["id"] == case["id"]) assert (mine["child_cases"], mine["matter_count"]) == (1, 2) assert [s["name"] for s in mine["shared_with"]] == ["Werkstatt"] # One matter is withheld from the room members in this case. ada.request( "PUT", "/api/v1/exceptions", json={"resource_kind": "matter", "resource_id": two["id"], "context": {"kind": "case", "id": case["id"]}, "remove_read": True}, ) seen = next(i for i in ben.request("GET", "/api/v1/cases")["items"] if i["id"] == case["id"]) assert seen["matter_count"] == 1 and seen["shared_with"] == [] and seen["is_owner"] is False assert child["title"] == "Nebenkosten" def test_a_room_shows_its_contents_to_members_only(world): ada, ben, cem, dan, room = world["ada"], world["ben"], world["cem"], world["dan"], world["room"] case = ada.request("POST", "/api/v1/cases", json={"title": "Im Raum"}, status=201) sub = ada.request( "POST", "/api/v1/cases", json={"title": "Unter der Akte", "parent_case_id": case["id"], "rights_mode": "inherit_parent"}, status=201, ) ada.request("POST", "/api/v1/cases", json={"title": "Bleibt privat"}, status=201) matter = matter_of(ada, "Vorgang im Raum") _share(ada, "cases", case["id"], room) _share(ada, "matters", matter["id"], room) for member in (ada, ben, cem): found = member.request("GET", f"/api/v1/rooms/{room}/contents") assert {c["title"] for c in found["cases"]} == {"Im Raum", "Unter der Akte"} assert [m["title"] for m in found["matters"]] == ["Vorgang im Raum"] dan.request("GET", f"/api/v1/rooms/{room}/contents", status=403) # A person who is excluded does not see the entry in the room either. ada.request("PUT", f"/api/v1/cases/{case['id']}/room-share/people/{_id(ada, ben)}", json={"excluded": True}) titles = {c["title"] for c in ben.request("GET", f"/api/v1/rooms/{room}/contents")["cases"]} assert "Im Raum" not in titles assert sub["title"] == "Unter der Akte" def test_the_room_overview_names_members_only_to_managers(world): ada, ben, room = world["ada"], world["ben"], world["room"] case = ada.request("POST", "/api/v1/cases", json={"title": "Gezählt"}, status=201) _share(ada, "cases", case["id"], room) mine = next(r for r in ada.request("GET", "/api/v1/rooms/overview")["items"] if r["id"] == room) assert mine["is_owner"] is True and mine["role"] == "manager" and mine["member_count"] == 3 assert mine["case_count"] == 1 and mine["matter_count"] == 0 assert set(mine["members"]) == {"Ada", "Ben", "Cem"} theirs = next(r for r in ben.request("GET", "/api/v1/rooms/overview")["items"] if r["id"] == room) assert theirs["members"] == [] and theirs["member_count"] == 3 and theirs["is_owner"] is False assert world["dan"].request("GET", "/api/v1/rooms/overview")["items"] == [] def test_several_entries_are_shared_at_once_or_not_at_all(world): ada, ben, room = world["ada"], world["ben"], world["room"] a = ada.request("POST", "/api/v1/cases", json={"title": "Eins"}, status=201) b = ada.request("POST", "/api/v1/cases", json={"title": "Zwei"}, status=201) m = matter_of(ada, "Drei") done = ada.request( "POST", f"/api/v1/rooms/{room}/shares", json={"items": [{"kind": "case", "id": a["id"]}, {"kind": "case", "id": b["id"]}, {"kind": "matter", "id": m["id"]}], "access": "read"}, ) assert done["shared"] == 3 assert {(e["display_name"], e["role"], e["rights"]["edit"]) for e in done["effect"]} == {("Ben", "member", False), ("Cem", "reader", False)} assert ben.request("GET", f"/api/v1/cases/{a['id']}")["rights"]["edit"] is False foreign = ben.request("POST", "/api/v1/cases", json={"title": "Von Ben"}, status=201) c = ada.request("POST", "/api/v1/cases", json={"title": "Vier"}, status=201) ada.request( "POST", f"/api/v1/rooms/{room}/shares", json={"items": [{"kind": "case", "id": c["id"]}, {"kind": "case", "id": foreign["id"]}]}, status=404, ) assert room not in [s["room_id"] for s in ada.request("GET", f"/api/v1/cases/{c['id']}/room-share")["shares"]] # An outsider cannot put his own entry into the room, and nobody shares an entry of someone else. own = world["dan"].request("POST", "/api/v1/cases", json={"title": "Von Dan"}, status=201) world["dan"].request("POST", f"/api/v1/rooms/{room}/shares", json={"items": [{"kind": "case", "id": own["id"]}]}, status=403) world["cem"].request("POST", f"/api/v1/rooms/{room}/shares", json={"items": [{"kind": "case", "id": c["id"]}]}, status=404) def test_creating_an_entry_can_put_it_into_a_room_and_reports_the_effect(world): ada, ben, room = world["ada"], world["ben"], world["room"] case = ada.request("POST", "/api/v1/cases", json={"title": "Gleich im Raum", "share_with_room_id": room}, status=201) matter = ada.request("POST", "/api/v1/matters", json={"title": "Vorgang im Raum", "share_with_room_id": room}, status=201) ben.request("GET", f"/api/v1/cases/{case['id']}") ben.request("GET", f"/api/v1/matters/{matter['id']}") other = ada.request("POST", "/api/v1/cases", json={"title": "Ohne Raum"}, status=201) ben.request("GET", f"/api/v1/cases/{other['id']}", status=404) answer = _share(ada, "cases", other["id"], room) assert {e["display_name"] for e in answer["effect"]} == {"Ben", "Cem"} world["dan"].request("POST", "/api/v1/cases", json={"title": "Fremd", "share_with_room_id": room}, status=403) def _id(owner: Actor, person: Actor) -> str: from app.core.settings import get_settings import psycopg with psycopg.connect(get_settings().dsn(), row_factory=psycopg.rows.dict_row) as conn: return str(conn.execute("SELECT id FROM auth_accounts WHERE email = %s", (person.email,)).fetchone()["id"])