"""Raumfreigabe: Mitglieder erhalten Rechte an Akten und Vorgängen ihres Raums nach Rolle.""" from __future__ import annotations import pytest from fastapi.testclient import TestClient from app.auth.accounts import create_account from tests.support import PASSWORD, Actor, document, matter_of, note_on def _second_client(): from app.main import app return TestClient(app) def _make(db, email: str, name: str, *, superadmin: bool = False): account = create_account(db, email, name, PASSWORD, is_superadmin=superadmin) db.commit() return account @pytest.fixture def world(client, db): """Ada owns the room; Ben is a member, Cem a reader, Dan is outside.""" actors = {} for key, email in (("ada", "ada-raum"), ("ben", "ben-raum"), ("cem", "cem-raum"), ("dan", "dan-raum")): actor = Actor(client if key == "ada" else _second_client(), f"{email}@example.test", key.title()) _make(db, actor.email, actor.name) actor.login() actors[key] = actor ada = actors["ada"] room = ada.request("POST", "/api/v1/rooms", json={"name": "Werkstatt"}, status=201) assert room["default_visibility"] == "room" ada.request("POST", f"/api/v1/rooms/{room['id']}/members", json={"email": actors["ben"].email, "role": "member"}) ada.request("POST", f"/api/v1/rooms/{room['id']}/members", json={"email": actors["cem"].email, "role": "reader"}) ada.use_room(room["id"]) actors["room"] = room["id"] return actors def _id(db, email: str) -> str: return str(db.execute("SELECT id FROM auth_accounts WHERE email = %s", (email,)).fetchone()["id"]) def test_the_room_share_gives_rights_by_role(world, db): ada, ben, cem, dan = world["ada"], world["ben"], world["cem"], world["dan"] shared = ada.request("POST", "/api/v1/cases", json={"title": "Gemeinsame Akte"}, status=201) assert ada.request("GET", f"/api/v1/cases/{shared['id']}/room-share")["visibility"] == "room" assert ben.request("GET", f"/api/v1/cases/{shared['id']}")["rights"] == { "read": True, "edit": True, "share": False, "delete": False, } assert cem.request("GET", f"/api/v1/cases/{shared['id']}")["rights"] == { "read": True, "edit": False, "share": False, "delete": False, } dan.request("GET", f"/api/v1/cases/{shared['id']}", status=404) titles = {item["title"] for item in ben.request("GET", "/api/v1/cases")["items"]} assert "Gemeinsame Akte" in titles assert dan.request("GET", "/api/v1/cases")["items"] == [] version = ben.request("GET", f"/api/v1/cases/{shared['id']}")["version"] ben.request("PATCH", f"/api/v1/cases/{shared['id']}", json={"expected_version": version, "title": "Von Ben geändert"}) cem.request("PATCH", f"/api/v1/cases/{shared['id']}", json={"expected_version": version + 1, "title": "Nein"}, status=403) ben.request("POST", f"/api/v1/cases/{shared['id']}/delete", json={"expected_version": version + 1}, status=403) ben.request( "POST", f"/api/v1/cases/{shared['id']}/grants", json={"email": dan.email, "can_read": True}, status=403, ) def test_private_cases_stay_private_and_the_owner_role_reads_nothing(world, db): ada, ben, cem = world["ada"], world["ben"], world["cem"] ada.request("POST", "/api/v1/cases", json={"title": "Vorab privat"}, status=201) own = ada.request("POST", "/api/v1/cases", json={"title": "Wird privat"}, status=201) ada.request("PUT", f"/api/v1/cases/{own['id']}/room-share", json={"visibility": "private"}) for member in (ben, cem): member.request("GET", f"/api/v1/cases/{own['id']}", status=404) # Ben creates his own case. Ada owns the room but is no reader of Ben's private case. ben.use_room(world["room"]) mine = ben.request("POST", "/api/v1/cases", json={"title": "Bens Akte"}, status=201) ben.request("PUT", f"/api/v1/cases/{mine['id']}/room-share", json={"visibility": "private"}) ada.request("GET", f"/api/v1/cases/{mine['id']}", status=404) assert "Bens Akte" not in {item["title"] for item in ada.request("GET", "/api/v1/cases")["items"]} # Only the owner of a case changes its room share. ada.request("PUT", f"/api/v1/cases/{mine['id']}/room-share", json={"visibility": "room"}, status=404) def test_leaving_the_room_or_going_private_takes_the_rights_back_at_once(world, db): ada, ben = world["ada"], world["ben"] case = ada.request("POST", "/api/v1/cases", json={"title": "Zeitweise sichtbar"}, status=201) ben.request("GET", f"/api/v1/cases/{case['id']}") ada.request("PUT", f"/api/v1/cases/{case['id']}/room-share", json={"visibility": "private"}) ben.request("GET", f"/api/v1/cases/{case['id']}", status=404) ada.request("PUT", f"/api/v1/cases/{case['id']}/room-share", json={"visibility": "room"}) ben.request("GET", f"/api/v1/cases/{case['id']}") ada.request("DELETE", f"/api/v1/rooms/{world['room']}/members/{_id(db, ben.email)}", status=204) ben.request("GET", f"/api/v1/cases/{case['id']}", status=404) assert ben.request("GET", "/api/v1/cases")["items"] == [] def test_an_archived_room_and_a_disabled_account_share_nothing(world, db): ada, ben = world["ada"], world["ben"] case = ada.request("POST", "/api/v1/cases", json={"title": "Archivtest"}, status=201) ben.request("GET", f"/api/v1/cases/{case['id']}") db.execute("UPDATE data_rooms SET status = 'archived' WHERE id = %s", (world["room"],)) db.commit() ben.request("GET", f"/api/v1/cases/{case['id']}", status=404) db.execute("UPDATE data_rooms SET status = 'active' WHERE id = %s", (world["room"],)) db.commit() ben.request("GET", f"/api/v1/cases/{case['id']}") def test_one_member_can_be_excluded_from_the_room_share(world, db): ada, ben, cem = world["ada"], world["ben"], world["cem"] case = ada.request("POST", "/api/v1/cases", json={"title": "Ohne Ben"}, status=201) view = ada.request("GET", f"/api/v1/cases/{case['id']}/room-share") assert {(m["display_name"], m["role"]) for m in view["members"]} == {("Ben", "member"), ("Cem", "reader")} ada.request("PUT", f"/api/v1/cases/{case['id']}/room-share/people/{_id(db, ben.email)}", json={"excluded": True}) ben.request("GET", f"/api/v1/cases/{case['id']}", status=404) cem.request("GET", f"/api/v1/cases/{case['id']}") assert any(m["excluded"] for m in ada.request("GET", f"/api/v1/cases/{case['id']}/room-share")["members"]) ada.request("PUT", f"/api/v1/cases/{case['id']}/room-share/people/{_id(db, ben.email)}", json={"excluded": False}) ben.request("GET", f"/api/v1/cases/{case['id']}") ada.request("PUT", f"/api/v1/cases/{case['id']}/room-share/people/{_id(db, ada.email)}", json={"excluded": True}, status=422) ada.request("PUT", f"/api/v1/cases/{case['id']}/room-share/people/{_id(db, world['dan'].email)}", json={"excluded": True}, status=404) ben.request("PUT", f"/api/v1/cases/{case['id']}/room-share/people/{_id(db, cem.email)}", json={"excluded": True}, status=404) def test_matters_and_their_contents_follow_the_room_role(world, db): ada, ben, cem, dan = world["ada"], world["ben"], world["cem"], world["dan"] case = ada.request("POST", "/api/v1/cases", json={"title": "Akte mit Vorgang"}, status=201) matter = ada.request( "POST", "/api/v1/matters", json={"title": "Vorgang im Raum", "context": {"kind": "case", "id": case["id"]}}, status=201, ) note = note_on(ada, "Notiz in der Akte", "Raumtext", case["id"]) detail = ben.request("GET", f"/api/v1/cases/{case['id']}") assert any(b["element"]["title"] == "Notiz in der Akte" for b in detail["bindings"]) ben.request( "PATCH", f"/api/v1/notes/{note['id']}", json={"expected_version": note["version"], "document": document("Von Ben ergänzt"), "context": {"kind": "case", "id": case["id"]}}, ) cem.request( "PATCH", f"/api/v1/notes/{note['id']}", json={"expected_version": note["version"] + 1, "document": document("Nein"), "context": {"kind": "case", "id": case["id"]}}, status=403, ) dan.request("GET", f"/api/v1/cases/{case['id']}", status=404) assert dan.request("GET", "/api/v1/search", params={"q": "Notiz in der Akte"})["items"] == [] assert any(item["title"] == "Notiz in der Akte" for item in cem.request("GET", "/api/v1/search", params={"q": "Notiz in der Akte"})["items"]) def test_a_standalone_matter_is_shared_by_its_own_setting(world, db): ada, ben, cem = world["ada"], world["ben"], world["cem"] matter = matter_of(ada, "Eigener Vorgang") assert ben.request("GET", f"/api/v1/matters/{matter['id']}")["rights"]["edit"] is True assert cem.request("GET", f"/api/v1/matters/{matter['id']}")["rights"] == { "read": True, "edit": False, "share": False, "delete": False, } ben.request("POST", f"/api/v1/matters/{matter['id']}/delete", json={"expected_version": matter["version"]}, status=403) ada.request("PUT", f"/api/v1/matters/{matter['id']}/room-share", json={"visibility": "private"}) ben.request("GET", f"/api/v1/matters/{matter['id']}", status=404) assert "Eigener Vorgang" not in {item["title"] for item in ben.request("GET", "/api/v1/matters")["items"]} def test_subcases_follow_their_parent_and_sub_matters_the_case(world, db): ada, ben = world["ada"], world["ben"] parent = ada.request("POST", "/api/v1/cases", json={"title": "Eltern"}, status=201) child = ada.request( "POST", "/api/v1/cases", json={"title": "Kind", "parent_case_id": parent["id"], "rights_mode": "inherit_parent"}, status=201, ) ben.request("GET", f"/api/v1/cases/{child['id']}") ada.request("PUT", f"/api/v1/cases/{parent['id']}/room-share", json={"visibility": "private"}) ben.request("GET", f"/api/v1/cases/{child['id']}", status=404) def test_the_personal_room_is_never_shared(client, db): ada = Actor(client, "ada-privat@example.test", "Ada Privat") _make(db, ada.email, ada.name) ada.login() case = ada.request("POST", "/api/v1/cases", json={"title": "Persönlich"}, status=201) assert db.execute("SELECT visibility FROM cases WHERE id = %s", (case["id"],)).fetchone()["visibility"] == "private" db.rollback() ada.request("PUT", f"/api/v1/cases/{case['id']}/room-share", json={"visibility": "room"}, status=422) def test_existing_content_stays_private_and_the_bulk_action_changes_only_own(world, db): ada, ben = world["ada"], world["ben"] old = ada.request("POST", "/api/v1/cases", json={"title": "Bestand"}, status=201) db.execute("UPDATE cases SET visibility = 'private' WHERE id = %s", (old["id"],)) db.commit() ben.request("GET", f"/api/v1/cases/{old['id']}", status=404) exposure = ada.request("GET", f"/api/v1/rooms/{world['room']}/exposure") assert exposure["cases"] == {"private": 1, "room": 0} assert ada.request("POST", f"/api/v1/rooms/{world['room']}/my-content/visibility", json={"visibility": "room"}) == {"changed": 1} ben.request("GET", f"/api/v1/cases/{old['id']}") ben.use_room(world["room"]) theirs = ben.request("POST", "/api/v1/cases", json={"title": "Bens"}, status=201) ada.request("POST", f"/api/v1/rooms/{world['room']}/my-content/visibility", json={"visibility": "private"}) ben.request("GET", f"/api/v1/cases/{theirs['id']}") world["dan"].request("GET", f"/api/v1/rooms/{world['room']}/exposure", status=403) def test_a_room_can_start_private(client, db): ada = Actor(client, "ada-start@example.test", "Ada Start") ben = Actor(_second_client(), "ben-start@example.test", "Ben Start") for actor in (ada, ben): _make(db, actor.email, actor.name) actor.login() room = ada.request("POST", "/api/v1/rooms", json={"name": "Privat", "default_visibility": "private"}, status=201) ada.use_room(room["id"]) case = ada.request("POST", "/api/v1/cases", json={"title": "Nur ich"}, status=201) ada.request("POST", f"/api/v1/rooms/{room['id']}/members", json={"email": ben.email, "role": "member"}) ben.request("GET", f"/api/v1/cases/{case['id']}", status=404) ada.request("PATCH", f"/api/v1/rooms/{room['id']}", json={"default_visibility": "room"}) other = ada.request("POST", "/api/v1/cases", json={"title": "Jetzt geteilt"}, status=201) ben.request("GET", f"/api/v1/cases/{other['id']}") ben.request("PATCH", f"/api/v1/rooms/{room['id']}", json={"default_visibility": "private"}, status=403)