"""Bibliothek: Zähler nur aus Lesbarem, Rauminhalt, Raumübersicht und Teilen im Stapel.""" from __future__ import annotations import pytest from fastapi.testclient import TestClient from app.auth.accounts import create_account from tests.support import PASSWORD, Actor, matter_of def _second_client(): from app.main import app return TestClient(app) def _actor(client, db, key: str, *, main: bool = False) -> Actor: actor = Actor(client if main else _second_client(), f"{key}-bib@example.test", key.title()) create_account(db, actor.email, actor.name, PASSWORD) db.commit() actor.login() return actor @pytest.fixture def world(client, db): ada = _actor(client, db, "ada", main=True) ben = _actor(client, db, "ben") cem = _actor(client, db, "cem") dan = _actor(client, db, "dan") room = ada.request("POST", "/api/v1/rooms", json={"name": "Werkstatt", "default_visibility": "private"}, status=201)["id"] ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": ben.email, "role": "member"}) ada.request("POST", f"/api/v1/rooms/{room}/members", json={"email": cem.email, "role": "reader"}) return {"ada": ada, "ben": ben, "cem": cem, "dan": dan, "room": room} def _share(actor, plural, resource_id, room, status=200): return actor.request("PUT", f"/api/v1/{plural}/{resource_id}/room-share/rooms/{room}", json={"access": "edit"}, status=status) def _link(actor, matter, case): actor.request("POST", f"/api/v1/matters/{matter}/case-links", json={"case_id": case}, status=201) def test_counts_include_only_what_the_person_may_read(world): ada, ben, room = world["ada"], world["ben"], world["room"] case = ada.request("POST", "/api/v1/cases", json={"title": "Vermietung"}, status=201) child = ada.request( "POST", "/api/v1/cases", json={"title": "Nebenkosten", "parent_case_id": case["id"], "rights_mode": "inherit_parent"}, status=201, ) one = matter_of(ada, "Mietminderung") two = matter_of(ada, "Eigenbedarf intern") _link(ada, one["id"], case["id"]) _link(ada, two["id"], case["id"]) _share(ada, "cases", case["id"], room) mine = next(i for i in ada.request("GET", "/api/v1/cases")["items"] if i["id"] == case["id"]) assert (mine["child_cases"], mine["matter_count"]) == (1, 2) assert [s["name"] for s in mine["shared_with"]] == ["Werkstatt"] # One matter is withheld from the room members in this case. ada.request( "PUT", "/api/v1/exceptions", json={"resource_kind": "matter", "resource_id": two["id"], "context": {"kind": "case", "id": case["id"]}, "remove_read": True}, ) seen = next(i for i in ben.request("GET", "/api/v1/cases")["items"] if i["id"] == case["id"]) assert seen["matter_count"] == 1 and seen["shared_with"] == [] and seen["is_owner"] is False assert child["title"] == "Nebenkosten" def test_a_room_shows_its_contents_to_members_only(world): ada, ben, cem, dan, room = world["ada"], world["ben"], world["cem"], world["dan"], world["room"] case = ada.request("POST", "/api/v1/cases", json={"title": "Im Raum"}, status=201) sub = ada.request( "POST", "/api/v1/cases", json={"title": "Unter der Akte", "parent_case_id": case["id"], "rights_mode": "inherit_parent"}, status=201, ) ada.request("POST", "/api/v1/cases", json={"title": "Bleibt privat"}, status=201) matter = matter_of(ada, "Vorgang im Raum") _share(ada, "cases", case["id"], room) _share(ada, "matters", matter["id"], room) for member in (ada, ben, cem): found = member.request("GET", f"/api/v1/rooms/{room}/contents") assert {c["title"] for c in found["cases"]} == {"Im Raum", "Unter der Akte"} assert [m["title"] for m in found["matters"]] == ["Vorgang im Raum"] dan.request("GET", f"/api/v1/rooms/{room}/contents", status=403) # A person who is excluded does not see the entry in the room either. ada.request("PUT", f"/api/v1/cases/{case['id']}/room-share/people/{_id(ada, ben)}", json={"excluded": True}) titles = {c["title"] for c in ben.request("GET", f"/api/v1/rooms/{room}/contents")["cases"]} assert "Im Raum" not in titles assert sub["title"] == "Unter der Akte" def test_the_room_overview_names_members_only_to_managers(world): ada, ben, room = world["ada"], world["ben"], world["room"] case = ada.request("POST", "/api/v1/cases", json={"title": "Gezählt"}, status=201) _share(ada, "cases", case["id"], room) mine = next(r for r in ada.request("GET", "/api/v1/rooms/overview")["items"] if r["id"] == room) assert mine["is_owner"] is True and mine["role"] == "manager" and mine["member_count"] == 3 assert mine["case_count"] == 1 and mine["matter_count"] == 0 assert set(mine["members"]) == {"Ada", "Ben", "Cem"} theirs = next(r for r in ben.request("GET", "/api/v1/rooms/overview")["items"] if r["id"] == room) assert theirs["members"] == [] and theirs["member_count"] == 3 and theirs["is_owner"] is False assert world["dan"].request("GET", "/api/v1/rooms/overview")["items"] == [] def test_several_entries_are_shared_at_once_or_not_at_all(world): ada, ben, room = world["ada"], world["ben"], world["room"] a = ada.request("POST", "/api/v1/cases", json={"title": "Eins"}, status=201) b = ada.request("POST", "/api/v1/cases", json={"title": "Zwei"}, status=201) m = matter_of(ada, "Drei") done = ada.request( "POST", f"/api/v1/rooms/{room}/shares", json={"items": [{"kind": "case", "id": a["id"]}, {"kind": "case", "id": b["id"]}, {"kind": "matter", "id": m["id"]}], "access": "read"}, ) assert done["shared"] == 3 assert {(e["display_name"], e["role"], e["rights"]["edit"]) for e in done["effect"]} == {("Ben", "member", False), ("Cem", "reader", False)} assert ben.request("GET", f"/api/v1/cases/{a['id']}")["rights"]["edit"] is False foreign = ben.request("POST", "/api/v1/cases", json={"title": "Von Ben"}, status=201) c = ada.request("POST", "/api/v1/cases", json={"title": "Vier"}, status=201) ada.request( "POST", f"/api/v1/rooms/{room}/shares", json={"items": [{"kind": "case", "id": c["id"]}, {"kind": "case", "id": foreign["id"]}]}, status=404, ) assert room not in [s["room_id"] for s in ada.request("GET", f"/api/v1/cases/{c['id']}/room-share")["shares"]] # An outsider cannot put his own entry into the room, and nobody shares an entry of someone else. own = world["dan"].request("POST", "/api/v1/cases", json={"title": "Von Dan"}, status=201) world["dan"].request("POST", f"/api/v1/rooms/{room}/shares", json={"items": [{"kind": "case", "id": own["id"]}]}, status=403) world["cem"].request("POST", f"/api/v1/rooms/{room}/shares", json={"items": [{"kind": "case", "id": c["id"]}]}, status=404) def test_creating_an_entry_can_put_it_into_a_room_and_reports_the_effect(world): ada, ben, room = world["ada"], world["ben"], world["room"] case = ada.request("POST", "/api/v1/cases", json={"title": "Gleich im Raum", "share_with_room_id": room}, status=201) matter = ada.request("POST", "/api/v1/matters", json={"title": "Vorgang im Raum", "share_with_room_id": room}, status=201) ben.request("GET", f"/api/v1/cases/{case['id']}") ben.request("GET", f"/api/v1/matters/{matter['id']}") other = ada.request("POST", "/api/v1/cases", json={"title": "Ohne Raum"}, status=201) ben.request("GET", f"/api/v1/cases/{other['id']}", status=404) answer = _share(ada, "cases", other["id"], room) assert {e["display_name"] for e in answer["effect"]} == {"Ben", "Cem"} world["dan"].request("POST", "/api/v1/cases", json={"title": "Fremd", "share_with_room_id": room}, status=403) def _id(owner: Actor, person: Actor) -> str: from app.core.settings import get_settings import psycopg with psycopg.connect(get_settings().dsn(), row_factory=psycopg.rows.dict_row) as conn: return str(conn.execute("SELECT id FROM auth_accounts WHERE email = %s", (person.email,)).fetchone()["id"]) def test_the_outline_lists_only_what_the_person_may_read(world): ada, ben, cem, dan, room = world["ada"], world["ben"], world["cem"], world["dan"], world["room"] case = ada.request("POST", "/api/v1/cases", json={"title": "Gliederung"}, status=201) ada.request("POST", f"/api/v1/cases/{case['id']}/chapters", json={"title": "Schriftverkehr"}, status=201) sub = ada.request( "POST", "/api/v1/cases", json={"title": "Unterakte", "parent_case_id": case["id"], "rights_mode": "inherit_parent"}, status=201, ) open_matter = matter_of(ada, "Offener Vorgang") hidden_matter = matter_of(ada, "Verborgener Vorgang") child = ada.request("POST", "/api/v1/matters", json={"title": "Teilvorgang", "parent_matter_id": open_matter["id"]}, status=201) ada.request("POST", f"/api/v1/matters/{open_matter['id']}/chapters", json={"title": "Belege"}, status=201) _link(ada, open_matter["id"], case["id"]) _link(ada, hidden_matter["id"], case["id"]) _share(ada, "cases", case["id"], room) ada.request( "PUT", "/api/v1/exceptions", json={"resource_kind": "matter", "resource_id": hidden_matter["id"], "context": {"kind": "case", "id": case["id"]}, "remove_read": True}, ) mine = ada.request("GET", f"/api/v1/cases/{case['id']}/outline") assert [c["title"] for c in mine["chapters"]] == ["Schriftverkehr"] assert [c["title"] for c in mine["subcases"]] == ["Unterakte"] # An exception in the case context hides the matter there for everyone, the owner included. assert {m["title"] for m in mine["matters"]} == {"Offener Vorgang"} seen = ben.request("GET", f"/api/v1/cases/{case['id']}/outline") assert {m["title"] for m in seen["matters"]} == {"Offener Vorgang"} assert [c["title"] for c in seen["matters"][0]["children"]] == ["Teilvorgang"] assert sub["id"] in [c["id"] for c in seen["subcases"]] matter = ada.request("GET", f"/api/v1/matters/{open_matter['id']}/outline") assert [c["title"] for c in matter["chapters"]] == ["Belege"] assert [c["title"] for c in matter["submatters"]] == ["Teilvorgang"] in_case = ben.request( "GET", f"/api/v1/matters/{open_matter['id']}/outline", params={"context_kind": "case", "context_id": case["id"]}, ) assert [c["title"] for c in in_case["submatters"]] == ["Teilvorgang"] ben.request("GET", f"/api/v1/matters/{open_matter['id']}/outline", status=404) assert child["title"] == "Teilvorgang" unknown = "00000000-0000-4000-8000-000000000000" seen_status = dan.request("GET", f"/api/v1/cases/{case['id']}/outline", status=404) missing = dan.request("GET", f"/api/v1/cases/{unknown}/outline", status=404) assert seen_status["detail"] == missing["detail"] dan.request("GET", f"/api/v1/matters/{open_matter['id']}/outline", status=404) assert cem.request("GET", f"/api/v1/cases/{case['id']}/outline")["id"] == case["id"] def test_unlinking_keeps_the_matter_and_its_other_cases(world): ada, ben = world["ada"], world["ben"] first = ada.request("POST", "/api/v1/cases", json={"title": "Vermietung"}, status=201)["id"] second = ada.request("POST", "/api/v1/cases", json={"title": "Steuer"}, status=201)["id"] matter = matter_of(ada, "Nebenkosten")["id"] ada.request("POST", f"/api/v1/matters/{matter}/case-links", json={"case_id": first}, status=201) ada.request("POST", f"/api/v1/matters/{matter}/case-links", json={"case_id": second}, status=201) links = ada.request("GET", f"/api/v1/matters/{matter}")["case_links"] assert {item["case_id"] for item in links} == {first, second} link = next(item for item in links if item["case_id"] == first) # A stranger cannot detach it and learns nothing about it. ben.request("DELETE", f"/api/v1/matter-case-links/{link['id']}", status=404) ada.request("DELETE", f"/api/v1/matter-case-links/{link['id']}", status=204) opened = ada.request("GET", f"/api/v1/matters/{matter}") assert [item["case_id"] for item in opened["case_links"]] == [second] assert opened["title"] == "Nebenkosten" assert matter in {item["id"] for item in ada.request("GET", "/api/v1/matters")["items"]} ada.request("DELETE", f"/api/v1/matter-case-links/{link['id']}", status=404) def test_download_policy_follows_the_room_role(world): ada, ben, cem, dan, room = world["ada"], world["ben"], world["cem"], world["dan"], world["room"] matter = matter_of(ada, "Nebenkosten")["id"] file = ada.request( "POST", "/api/v1/files", data={"title": "Vertrag", "context_kind": "matter", "context_id": matter}, files={"upload": ("vertrag.pdf", b"%PDF-1.4\n1 0 obj<<>>endobj\ntrailer<<>>\n%%EOF\n", "application/pdf")}, status=201, )["id"] _share(ada, "matters", matter, room) path = f"/api/v1/files/{file}/content" query = {"context_kind": "matter", "context_id": matter} def fetch(person, **extra): from tests.support import ORIGIN headers = {"Origin": ORIGIN, "X-CSRF-Token": person.csrf} if person.scope is not None: headers["X-Scope-Kind"], headers["X-Scope-Id"] = person.scope["kind"], person.scope["id"] return person.client.get(path, params={**query, **extra}, headers=headers) # By default every role may save the original. for person in (ben, cem): assert fetch(person, save="true").status_code == 200 seen = ben.request("GET", f"/api/v1/matters/{matter}") assert seen["rights"]["download"] is True # The owner turns it off for readers. Reading stays possible, saving does not. assert cem.request("GET", f"/api/v1/rooms/{room}/download-policy")["can_change"] is False cem.request("PUT", f"/api/v1/rooms/{room}/download-policy", json={"manager": True, "member": True, "reader": False}, status=403) ada.request("PUT", f"/api/v1/rooms/{room}/download-policy", json={"manager": True, "member": True, "reader": False}) assert fetch(cem).status_code == 200 refused = fetch(cem, save="true") assert refused.status_code == 403 assert "freigegeben" in refused.json()["detail"] assert cem.request("GET", f"/api/v1/matters/{matter}")["rights"]["download"] is False assert fetch(ben, save="true").status_code == 200 # A stranger learns nothing about the policy of the room. dan.request("GET", f"/api/v1/rooms/{room}/download-policy", status=404) # The owner's default is copied into a new room. ada.request("PUT", "/api/v1/auth/download-defaults", json={"manager": True, "member": False, "reader": False, "direct": True}) fresh = ada.request("POST", "/api/v1/rooms", json={"name": "Neu", "default_visibility": "private"}, status=201)["id"] assert ada.request("GET", f"/api/v1/rooms/{fresh}/download-policy")["roles"] == {"manager": True, "member": False, "reader": False} assert ada.request("GET", f"/api/v1/rooms/{room}/download-policy")["roles"]["member"] is True