Enhance Path Evaluation and Slot Management Features
Deploy Development / deploy (push) Successful in 44s
Test Suite / pytest-backend (push) Successful in 44s
Test Suite / lint-backend (push) Successful in 0s
Test Suite / build-frontend (push) Successful in 14s
Test Suite / k6 /health Baseline (push) Successful in 34s
Test Suite / playwright-tests (push) Successful in 1m13s
Deploy Development / deploy (push) Successful in 44s
Test Suite / pytest-backend (push) Successful in 44s
Test Suite / lint-backend (push) Successful in 0s
Test Suite / build-frontend (push) Successful in 14s
Test Suite / k6 /health Baseline (push) Successful in 34s
Test Suite / playwright-tests (push) Successful in 1m13s
- Introduced `_parse_slot_refs_from_text` to extract and convert slot references from text, improving the handling of user input in path evaluations. - Updated `_problematic_slots_from_path_qa` to utilize the new parsing function, enhancing the identification of problematic slots based on various hints and issues. - Enhanced `ProgressionGraphEditor` and `ProgressionOptimizeCompareModal` to better display identified problem slots and their associated reasons, improving user feedback during evaluations. - Added tests for new parsing functionality and its integration with existing slot management processes, ensuring robustness in slot reference handling.
This commit is contained in:
1 parent
3468b2066e
commit
e9bf5bd1a5
4 files changed
+207
-39
No files matched your search
@@ -1,5 +1,6 @@
|
||||
"""Schachstellen-Erkennung für unified Slot-Review."""
|
||||
from planning_exercise_path_builder import (
|
||||
_parse_slot_refs_from_text,
|
||||
_problematic_slots_from_path_qa,
|
||||
_slot_suggestion_accepted,
|
||||
)
|
||||
@@ -51,3 +52,46 @@ def test_slot_suggestion_accepted_for_problem_slot():
|
||||
major_idx=1,
|
||||
slot_problem=True,
|
||||
)
|
||||
|
||||
|
||||
def test_parse_slot_refs_schritt_is_one_based():
|
||||
assert _parse_slot_refs_from_text("Schritt 8 (Ukemi Vorwärts) entfernen") == {7}
|
||||
assert _parse_slot_refs_from_text("slot 3 und Stufe 5") == {2, 4}
|
||||
|
||||
|
||||
def test_problematic_slots_from_refine_stage_spec_hint():
|
||||
qa = {
|
||||
"optimization_hints": [
|
||||
{
|
||||
"action": "refine_stage_spec",
|
||||
"step_index": 7,
|
||||
"issue": "stage_mismatch",
|
||||
"reason": "Stufen-Fit zu schwach (0.00) für „Integration von Täuschung“",
|
||||
}
|
||||
],
|
||||
"off_topic_steps": [],
|
||||
}
|
||||
steps = [
|
||||
{"roadmap_major_step_index": i, "exercise_id": i + 1, "title": f"Übung {i + 1}"}
|
||||
for i in range(8)
|
||||
]
|
||||
steps[7]["title"] = "Ukemi Vorwärts"
|
||||
specs = [_spec(i) for i in range(8)]
|
||||
problems = _problematic_slots_from_path_qa(qa, steps, specs)
|
||||
assert 7 in problems
|
||||
|
||||
|
||||
def test_problematic_slots_from_llm_schritt_text():
|
||||
qa = {
|
||||
"optimization_hints": [],
|
||||
"off_topic_steps": [],
|
||||
"issues": [
|
||||
"Schritt 8 (Ukemi Vorwärts) hat keinen Bezug zur Kumite-Beinarbeit",
|
||||
],
|
||||
}
|
||||
steps = [
|
||||
{"roadmap_major_step_index": 7, "exercise_id": 99, "title": "Ukemi Vorwärts"},
|
||||
]
|
||||
specs = [_spec(7)]
|
||||
problems = _problematic_slots_from_path_qa(qa, steps, specs)
|
||||
assert 7 in problems
|
||||
Reference in new issue
Block a user