Enhance Skill Tree Components with Improved Group Labeling and Default Expansion
Deploy Development / deploy (push) Successful in 40s
Test Suite / pytest-backend (push) Successful in 38s
Test Suite / lint-backend (push) Successful in 0s
Test Suite / build-frontend (push) Successful in 14s
Test Suite / k6 /health Baseline (push) Successful in 33s
Test Suite / playwright-tests (push) Has been cancelled

- Added CSS styles for skill group labels in the skill tree to improve visual hierarchy and readability.
- Updated `SkillTreePickerPanel` and `SkillTreeMultiSelect` components to utilize the new default expansion logic, ensuring main and category nodes are open by default while skill groups remain collapsed.
- Refactored state management in `SkillTreePickerPanel` to align with the new default expansion behavior.
- Enhanced utility functions to support the new default expansion logic for skill trees.
This commit is contained in:
Lars committed 2026-05-20 11:13:34 +02:00
1 parent 46feb4c867
commit 9020e5eb16
6 files changed
+79 -23

No files matched your search

@@ -4,6 +4,7 @@ import {
allExpandableKeys,
buildSkillCatalogTree,
collectSkillLeavesFromTree,
defaultExpandedKeysForSkillTree,
filterSkillTreeByQuery,
} from '../utils/skillCatalogTree'
@@ -54,7 +55,13 @@ function SkillTreeNodes({ nodes, depth, expanded, exclude, onToggle, onPickSkill
) : (
<span className="skill-tree__toggle-spacer" aria-hidden />
)}
<span className={`skill-tree__group-label skill-tree__group-label--${node.type}`}>{node.label}</span>
<span
className={`skill-tree__group-label skill-tree__group-label--${node.type}${
node.type === 'skillGroup' ? ' skill-tree__group-label--skill-group' : ''
}`}
>
{node.label}
</span>
</div>
{hasKids && isOpen ? (
<ul className="skill-tree__children" role={pickMode === 'multi' ? 'group' : 'tree'}>
@@ -75,7 +82,7 @@ function SkillTreeNodes({ nodes, depth, expanded, exclude, onToggle, onPickSkill
}
/**
* Ausklappbare Baumliste für Fähigkeiten (Hauptgruppe → Kategorie → Fähigkeit).
* Ausklappbare Baumliste: Hauptgruppe → Kategorie (beide standard offen) → Fähigkeiten-Gruppe (standard zu).
*/
export default function SkillTreePickerPanel({
skills = [],
@@ -84,8 +91,6 @@ export default function SkillTreePickerPanel({
onPickSkill,
pickMode = 'single',
className = '',
/** true: nur Hauptgruppen sichtbar, bis der Nutzer aufklappt (Filter) */
defaultCollapsed = true,
}) {
const exclude = useMemo(() => normExclude(excludeIds), [excludeIds])
const fullTree = useMemo(() => buildSkillCatalogTree(skills), [skills])
@@ -98,16 +103,16 @@ export default function SkillTreePickerPanel({
useEffect(() => {
if (searchQuery.trim()) {
setExpanded(new Set(allExpandableKeys(displayTree)))
} else if (defaultCollapsed) {
setExpanded(new Set())
} else {
setExpanded(new Set(defaultExpandedKeysForSkillTree(displayTree)))
}
}, [searchQuery, displayTree, defaultCollapsed])
}, [searchQuery, displayTree])
useEffect(() => {
if (!defaultCollapsed) {
setExpanded(new Set(allExpandableKeys(fullTree)))
if (!searchQuery.trim()) {
setExpanded(new Set(defaultExpandedKeysForSkillTree(fullTree)))
}
}, [fullTree, defaultCollapsed])
}, [fullTree, searchQuery])
const onToggle = useCallback((key) => {
setExpanded((prev) => {