Enhance Path Quality Assessment and Slot Management Features
Deploy Development / deploy (push) Successful in 42s
Test Suite / pytest-backend (push) Successful in 44s
Test Suite / lint-backend (push) Successful in 0s
Test Suite / build-frontend (push) Successful in 13s
Test Suite / k6 /health Baseline (push) Successful in 34s
Test Suite / playwright-tests (push) Successful in 1m13s
Deploy Development / deploy (push) Successful in 42s
Test Suite / pytest-backend (push) Successful in 44s
Test Suite / lint-backend (push) Successful in 0s
Test Suite / build-frontend (push) Successful in 13s
Test Suite / k6 /health Baseline (push) Successful in 34s
Test Suite / playwright-tests (push) Successful in 1m13s
- Added new functions for computing assignment quality scores and counting step assignment statistics, improving the evaluation of steps in path quality assessments. - Updated existing methods to incorporate the new scoring logic, enhancing the robustness of path evaluations. - Introduced UI components in the frontend to display detailed quality assessment results, including handling of split dimensions in path evaluations. - Enhanced tests to cover new functionalities and ensure accuracy in quality scoring and slot management processes.
This commit is contained in:
1 parent
7265cd5a01
commit
313d613b7c
8 files changed
+427
-55
No files matched your search
@@ -11,6 +11,8 @@ import {
|
||||
formatRefineLogEntry,
|
||||
hasRematchSlotHints,
|
||||
pathQaQualityPercent,
|
||||
pathQaHasSplitDimensions,
|
||||
pathQaSubsectionPercent,
|
||||
pathQaShowsStrongResult,
|
||||
resolveHintSlotIndex,
|
||||
resolveOfferSlotIndex,
|
||||
@@ -26,6 +28,46 @@ function severityStyle(pathQa) {
|
||||
}
|
||||
}
|
||||
|
||||
function subsectionSeverityStyle(subsection) {
|
||||
if (!subsection) return {}
|
||||
return {
|
||||
background: subsection.overall_ok
|
||||
? 'color-mix(in srgb, var(--accent) 6%, var(--surface))'
|
||||
: 'color-mix(in srgb, var(--danger) 10%, var(--surface))',
|
||||
border: `1px solid ${subsection.overall_ok ? 'var(--border)' : 'color-mix(in srgb, var(--danger) 35%, var(--border))'}`,
|
||||
}
|
||||
}
|
||||
|
||||
function PathQaDimensionBlock({ title, subsection, children = null }) {
|
||||
if (!subsection) return null
|
||||
const pct = pathQaSubsectionPercent(subsection)
|
||||
return (
|
||||
<div
|
||||
style={{
|
||||
marginTop: '10px',
|
||||
padding: '8px 10px',
|
||||
borderRadius: '8px',
|
||||
fontSize: '11px',
|
||||
lineHeight: 1.45,
|
||||
...subsectionSeverityStyle(subsection),
|
||||
}}
|
||||
>
|
||||
<strong>
|
||||
{title}: {subsection.overall_ok ? 'OK' : 'Hinweise'}
|
||||
{pct != null ? ` (${pct} %)` : ''}
|
||||
</strong>
|
||||
{Array.isArray(subsection.issues) && subsection.issues.length > 0 ? (
|
||||
<ul style={{ margin: '6px 0 0', paddingLeft: '16px', color: 'var(--text2)' }}>
|
||||
{subsection.issues.slice(0, 5).map((issue) => (
|
||||
<li key={`${title}-${issue}`}>{issue}</li>
|
||||
))}
|
||||
</ul>
|
||||
) : null}
|
||||
{children}
|
||||
</div>
|
||||
)
|
||||
}
|
||||
|
||||
function PathQaPipelineDetails({ pathQa, fairQa = null, draft, title, compact = false }) {
|
||||
const { fixHints: optimizationHints } = useMemo(
|
||||
() => splitPathQaHints(pathQa),
|
||||
@@ -310,6 +352,9 @@ export default function ProgressionFindingsPanel({
|
||||
&& (canOptimizeCompare || pathQa?.assignments_preserved || showRematchAction)
|
||||
const qualityPct = pathQaQualityPercent(pathQa)
|
||||
const strongResult = pathQaShowsStrongResult(pathQa)
|
||||
const hasSplitQa = pathQaHasSplitDimensions(pathQa)
|
||||
const roadmapQa = pathQa?.roadmap_qa || null
|
||||
const assignmentQa = pathQa?.assignment_qa || null
|
||||
|
||||
return (
|
||||
<div className="card" style={{ position: 'sticky', top: '12px' }}>
|
||||
@@ -364,9 +409,14 @@ export default function ProgressionFindingsPanel({
|
||||
}}
|
||||
>
|
||||
<strong>
|
||||
Pfad-QS: {pathQa.overall_ok ? 'OK' : 'Hinweise'}
|
||||
Pfad-QS gesamt: {pathQa.overall_ok ? 'OK' : 'Hinweise'}
|
||||
{qualityPct != null ? ` (${qualityPct} %)` : ''}
|
||||
</strong>
|
||||
{hasSplitQa ? (
|
||||
<p style={{ margin: '6px 0 0', color: 'var(--text2)', fontSize: '11px' }}>
|
||||
Gesamt = schwächere Dimension (Roadmap vs. Übungsbesetzung).
|
||||
</p>
|
||||
) : null}
|
||||
{pathQa.assignments_preserved ? (
|
||||
<p style={{ margin: '6px 0 0', color: 'var(--text2)', fontSize: '11px' }}>
|
||||
Bewertung des aktuellen Pfads. „Übungen matchen“ öffnet einen Dialog mit Vorschlägen für
|
||||
@@ -378,7 +428,23 @@ export default function ProgressionFindingsPanel({
|
||||
Starker Pfad — KI-Empfehlungen unten können Feinschliff oder optionale Vertiefung sein.
|
||||
</p>
|
||||
) : null}
|
||||
{pathQa.topic_coverage ? (
|
||||
{hasSplitQa ? (
|
||||
<>
|
||||
<PathQaDimensionBlock title="Roadmap & Stufen" subsection={roadmapQa}>
|
||||
{roadmapQa?.topic_coverage ? (
|
||||
<p style={{ margin: '6px 0 0', color: 'var(--text2)' }}>{roadmapQa.topic_coverage}</p>
|
||||
) : null}
|
||||
</PathQaDimensionBlock>
|
||||
<PathQaDimensionBlock title="Übungsbesetzung" subsection={assignmentQa}>
|
||||
{assignmentQa?.empty_slot_count > 0 ? (
|
||||
<p style={{ margin: '6px 0 0', color: 'var(--danger)' }}>
|
||||
{assignmentQa.empty_slot_count} leere Slot(s) — „Übungen matchen“ oder manuell befüllen.
|
||||
</p>
|
||||
) : null}
|
||||
</PathQaDimensionBlock>
|
||||
</>
|
||||
) : null}
|
||||
{!hasSplitQa && pathQa.topic_coverage ? (
|
||||
<p style={{ margin: '6px 0 0', color: 'var(--text2)' }}>{pathQa.topic_coverage}</p>
|
||||
) : null}
|
||||
{highlightTexts.length > 0 ? (
|
||||
@@ -415,7 +481,7 @@ export default function ProgressionFindingsPanel({
|
||||
</ul>
|
||||
</>
|
||||
) : null}
|
||||
{Array.isArray(pathQa.issues) && pathQa.issues.length > 0 ? (
|
||||
{Array.isArray(pathQa.issues) && pathQa.issues.length > 0 && !hasSplitQa ? (
|
||||
<ul style={{ margin: '6px 0 0', paddingLeft: '16px', color: 'var(--text2)' }}>
|
||||
{pathQa.issues.map((issue) => (
|
||||
<li key={issue}>{issue}</li>
|
||||
|
||||
@@ -6,7 +6,9 @@ import FormModalOverlay from './FormModalOverlay'
|
||||
import {
|
||||
compareSlotReviews,
|
||||
defaultSelectedCompareDiffs,
|
||||
pathQaHasSplitDimensions,
|
||||
pathQaQualityPercent,
|
||||
pathQaSubsectionPercent,
|
||||
qualityDeltaPercent,
|
||||
rejectedCompareDiffs,
|
||||
slotFitScorePercent,
|
||||
@@ -189,6 +191,9 @@ function SlotReviewRow({ review, selected, onToggle, applying }) {
|
||||
<strong>KI-Vorschlag nutzen</strong>
|
||||
<span style={{ display: 'block', fontSize: '11px', color: 'var(--text3)', marginTop: '2px' }}>
|
||||
{ai.title_hint || 'Neue Übung per KI entwerfen'}
|
||||
{ai.auto_select
|
||||
? ' — empfohlen, Bibliothek passt nicht ausreichend zum Stufen-Ziel'
|
||||
: ''}
|
||||
</span>
|
||||
</span>
|
||||
</label>
|
||||
@@ -223,6 +228,9 @@ export default function ProgressionOptimizeCompareModal({
|
||||
|
||||
const baselineQa = comparison.baseline_path_qa
|
||||
const baselinePct = pathQaQualityPercent(baselineQa)
|
||||
const hasSplitQa = pathQaHasSplitDimensions(baselineQa)
|
||||
const roadmapPct = pathQaSubsectionPercent(baselineQa?.roadmap_qa)
|
||||
const assignmentPct = pathQaSubsectionPercent(baselineQa?.assignment_qa)
|
||||
const rejectedCount = rejected.length
|
||||
const reviewError = comparison.review_error || null
|
||||
|
||||
@@ -258,8 +266,9 @@ export default function ProgressionOptimizeCompareModal({
|
||||
{title}
|
||||
</h3>
|
||||
<p style={{ fontSize: '12px', color: 'var(--text3)', marginTop: 0, lineHeight: 1.45 }}>
|
||||
Je Slot: aktuelle Bewertung, beste Bibliotheks-Alternative und optional KI. Haken nur
|
||||
vorausgewählt, wenn die Alternative einen höheren Stufen-Fit hat.
|
||||
Je Slot: aktuelle Bewertung, beste Bibliotheks-Alternative und optional KI. Vorauswahl:
|
||||
Bibliothek nur bei klar besserem Stufen-Fit; bei leeren oder schwach passenden Slots eher
|
||||
KI-Vorschlag.
|
||||
</p>
|
||||
|
||||
{reviewError ? (
|
||||
@@ -289,9 +298,19 @@ export default function ProgressionOptimizeCompareModal({
|
||||
>
|
||||
<strong>Dein Pfad</strong>
|
||||
<div style={{ marginTop: '6px' }}>{qaLabel(baselineQa)}</div>
|
||||
{baselineQa?.topic_coverage ? (
|
||||
{hasSplitQa ? (
|
||||
<div style={{ marginTop: '6px', fontSize: '11px', color: 'var(--text2)', lineHeight: 1.45 }}>
|
||||
Roadmap {roadmapPct != null ? `${roadmapPct} %` : '—'}
|
||||
{' · '}
|
||||
Besetzung {assignmentPct != null ? `${assignmentPct} %` : '—'}
|
||||
</div>
|
||||
) : null}
|
||||
{!hasSplitQa && baselineQa?.topic_coverage ? (
|
||||
<p style={{ margin: '6px 0 0', color: 'var(--text2)' }}>{baselineQa.topic_coverage}</p>
|
||||
) : null}
|
||||
{hasSplitQa && baselineQa?.roadmap_qa?.topic_coverage ? (
|
||||
<p style={{ margin: '6px 0 0', color: 'var(--text2)' }}>{baselineQa.roadmap_qa.topic_coverage}</p>
|
||||
) : null}
|
||||
</div>
|
||||
|
||||
{rejectedCount > 0 ? (
|
||||
|
||||
@@ -173,8 +173,19 @@ export function pathQaQualityPercent(pathQa) {
|
||||
return Math.round(Number(pathQa.quality_score) * 100)
|
||||
}
|
||||
|
||||
export function pathQaSubsectionPercent(subsection) {
|
||||
if (subsection?.quality_score == null || !Number.isFinite(Number(subsection.quality_score))) return null
|
||||
return Math.round(Number(subsection.quality_score) * 100)
|
||||
}
|
||||
|
||||
export function pathQaHasSplitDimensions(pathQa) {
|
||||
return Boolean(pathQa?.roadmap_qa || pathQa?.assignment_qa)
|
||||
}
|
||||
|
||||
export function pathQaShowsStrongResult(pathQa) {
|
||||
const pct = pathQaQualityPercent(pathQa)
|
||||
const assignmentOk = pathQa?.assignment_qa ? pathQa.assignment_qa.overall_ok !== false : true
|
||||
if (!assignmentOk) return false
|
||||
if (pathQa?.overall_ok && pct != null && pct >= 85) return true
|
||||
return Boolean(pathQa?.overall_ok && pct != null && pct >= 80 && !(pathQa?.issues || []).length)
|
||||
}
|
||||
@@ -1073,9 +1084,16 @@ export function compareDiffsForDialog(comparison) {
|
||||
export function defaultSelectedCompareDiffs(comparison) {
|
||||
const reviews = compareSlotReviews(comparison)
|
||||
if (reviews.length > 0) {
|
||||
return reviews
|
||||
.filter((review) => review?.library_alternative?.auto_select)
|
||||
.map((review) => slotReviewSelectionKey(review.roadmap_major_step_index, 'library'))
|
||||
const keys = []
|
||||
for (const review of reviews) {
|
||||
const midx = review.roadmap_major_step_index
|
||||
if (review?.ai_alternative?.auto_select) {
|
||||
keys.push(slotReviewSelectionKey(midx, 'ai'))
|
||||
} else if (review?.library_alternative?.auto_select) {
|
||||
keys.push(slotReviewSelectionKey(midx, 'library'))
|
||||
}
|
||||
}
|
||||
return keys
|
||||
}
|
||||
return compareDiffsForDialog(comparison).map((d) => Number(d.roadmap_major_step_index))
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user