Enhance Stage Matching and Retrieval Logic in Planning Exercise
Deploy Development / deploy (push) Successful in 43s
Test Suite / pytest-backend (push) Successful in 44s
Test Suite / lint-backend (push) Successful in 0s
Test Suite / build-frontend (push) Successful in 13s
Test Suite / k6 /health Baseline (push) Successful in 34s
Test Suite / playwright-tests (push) Successful in 1m16s
Deploy Development / deploy (push) Successful in 43s
Test Suite / pytest-backend (push) Successful in 44s
Test Suite / lint-backend (push) Successful in 0s
Test Suite / build-frontend (push) Successful in 13s
Test Suite / k6 /health Baseline (push) Successful in 34s
Test Suite / playwright-tests (push) Successful in 1m16s
- Introduced `build_stage_match_brief` to create stage-specific semantic briefs, improving roadmap matching accuracy. - Updated path retrieval logic to differentiate between general and stage-specific semantic weights, enhancing exercise relevance. - Added support for anti-patterns and success criteria in stage matching, allowing for more nuanced exercise selection. - Enhanced tests to validate new stage matching features and ensure correct functionality against learning goals. - Incremented application version to reflect these updates.
This commit is contained in:
1 parent
18547613ea
commit
07e147bc76
6 files changed
+591
-81
No files matched your search
@@ -1,7 +1,9 @@
|
||||
"""Tests Roadmap-Stufen-Match — Gate gegen themenfremde Übungen."""
|
||||
from planning_exercise_semantics import (
|
||||
build_stage_match_brief,
|
||||
exercise_passes_stage_learning_goal_gate,
|
||||
pick_best_path_hit,
|
||||
score_exercise_stage_fit,
|
||||
semantic_brief_for_stage,
|
||||
build_semantic_brief,
|
||||
)
|
||||
@@ -35,10 +37,37 @@ def test_semantic_brief_for_stage_adds_learning_goal():
|
||||
assert "hüftmobilität und kammerhaltung" in stage.must_phrases[0]
|
||||
|
||||
|
||||
def test_build_stage_match_brief_uses_stage_tokens_not_global_topic():
|
||||
brief = build_stage_match_brief(
|
||||
learning_goal="Koordination von Absprung und Beinhebung ohne Tritttechnik",
|
||||
phase="vertiefung",
|
||||
)
|
||||
must_blob = " ".join(brief.must_phrases or []).lower()
|
||||
assert "mawashi" not in must_blob
|
||||
assert "absprung" in must_blob
|
||||
assert not (brief.primary_topic or "").strip()
|
||||
|
||||
|
||||
def test_stage_fit_prefers_goal_over_misleading_title():
|
||||
stage_goal = "Koordination von Absprung und Beinhebung ohne Tritttechnik"
|
||||
stage_brief = build_stage_match_brief(learning_goal=stage_goal)
|
||||
kick_score, _ = score_exercise_stage_fit(
|
||||
title="Mawashi Geri Trittpräzision",
|
||||
summary="Kicktechnik",
|
||||
goal="Präzision im Tritt und Hüftarbeit",
|
||||
stage_brief=stage_brief,
|
||||
)
|
||||
coord_score, _ = score_exercise_stage_fit(
|
||||
title="Allgemeines Sprungtraining",
|
||||
summary="Athletik",
|
||||
goal="Absprung, Beinhebung und Landung koordinieren — ohne Trittausführung",
|
||||
stage_brief=stage_brief,
|
||||
)
|
||||
assert coord_score > kick_score
|
||||
|
||||
|
||||
def test_pick_best_path_hit_roadmap_stage_no_weak_fallback():
|
||||
brief = build_semantic_brief("Mae Geri Perfektion")
|
||||
stage_brief = semantic_brief_for_stage(
|
||||
brief,
|
||||
stage_brief = build_stage_match_brief(
|
||||
learning_goal="Hüftmobilität für Mae Geri",
|
||||
phase="grundlage",
|
||||
)
|
||||
@@ -69,9 +98,7 @@ def test_pick_best_path_hit_roadmap_stage_no_weak_fallback():
|
||||
|
||||
|
||||
def test_pick_best_path_hit_roadmap_stage_picks_relevant():
|
||||
brief = build_semantic_brief("Mae Geri Perfektion")
|
||||
stage_brief = semantic_brief_for_stage(
|
||||
brief,
|
||||
stage_brief = build_stage_match_brief(
|
||||
learning_goal="Hüftmobilität für Mae Geri",
|
||||
phase="grundlage",
|
||||
)
|
||||
@@ -94,3 +121,63 @@ def test_pick_best_path_hit_roadmap_stage_picks_relevant():
|
||||
)
|
||||
assert chosen is not None
|
||||
assert int(chosen["id"]) == 2
|
||||
|
||||
|
||||
def test_stage_gate_rejects_tritt_when_goal_says_ohne_tritttechnik():
|
||||
"""Regression: gesprungener Mawashi — Slot Koordination ohne Tritttechnik."""
|
||||
goal = "Koordination von Absprung und Beinhebung ohne Tritttechnik"
|
||||
assert not exercise_passes_stage_learning_goal_gate(
|
||||
learning_goal=goal,
|
||||
title="Verbesserung der Trittpräzision des Mawashi Geri und der Hüftbewegung",
|
||||
summary="Präzision und Hüftarbeit im Stand",
|
||||
semantic_score=0.72,
|
||||
)
|
||||
|
||||
|
||||
def test_stage_gate_accepts_absprung_drill_not_kick_focus():
|
||||
goal = "Koordination von Absprung und Beinhebung ohne Tritttechnik"
|
||||
assert exercise_passes_stage_learning_goal_gate(
|
||||
learning_goal=goal,
|
||||
title="Sprungkoordination — Absprung und Beinhebung",
|
||||
summary="Ohne Trittausführung, Fokus Gleichgewicht und Timing",
|
||||
semantic_score=0.35,
|
||||
)
|
||||
|
||||
|
||||
def test_pick_best_rejects_mawashi_tritt_precision_for_coordination_slot():
|
||||
stage_goal = "Koordination von Absprung und Beinhebung ohne Tritttechnik"
|
||||
stage_brief = build_stage_match_brief(learning_goal=stage_goal, phase="vertiefung")
|
||||
hits = [
|
||||
{
|
||||
"id": 99,
|
||||
"title": "Verbesserung der Trittpräzision des Mawashi Geri und der Hüftbewegung",
|
||||
"summary": "Tritttechnik und Hüfte im Stand",
|
||||
"score": 0.91,
|
||||
"semantic_score": 0.68,
|
||||
},
|
||||
{
|
||||
"id": 100,
|
||||
"title": "Absprung und Beinhebung — Koordination ohne Kick",
|
||||
"summary": "Sprungvorbereitung, kein Tritt",
|
||||
"score": 0.62,
|
||||
"semantic_score": 0.41,
|
||||
},
|
||||
]
|
||||
chosen = pick_best_path_hit(
|
||||
hits,
|
||||
set(),
|
||||
semantic_brief=stage_brief,
|
||||
stage_learning_goal=stage_goal,
|
||||
roadmap_stage_match=True,
|
||||
)
|
||||
assert chosen is not None
|
||||
assert int(chosen["id"]) == 100
|
||||
|
||||
|
||||
def test_parse_stage_goal_constraints_extracts_ohne_tritttechnik():
|
||||
from planning_exercise_semantics import parse_stage_goal_constraints
|
||||
|
||||
c = parse_stage_goal_constraints("Koordination von Absprung und Beinhebung ohne Tritttechnik")
|
||||
assert c.has_negation
|
||||
assert "absprung" in c.positive_tokens
|
||||
assert any("tritt" in ex for ex in c.exclude_phrases)
|
||||
Reference in new issue
Block a user