Enhance Stage Matching and Retrieval Logic in Planning Exercise
Deploy Development / deploy (push) Successful in 43s
Test Suite / pytest-backend (push) Successful in 44s
Test Suite / lint-backend (push) Successful in 0s
Test Suite / build-frontend (push) Successful in 13s
Test Suite / k6 /health Baseline (push) Successful in 34s
Test Suite / playwright-tests (push) Successful in 1m16s
Deploy Development / deploy (push) Successful in 43s
Test Suite / pytest-backend (push) Successful in 44s
Test Suite / lint-backend (push) Successful in 0s
Test Suite / build-frontend (push) Successful in 13s
Test Suite / k6 /health Baseline (push) Successful in 34s
Test Suite / playwright-tests (push) Successful in 1m16s
- Introduced `build_stage_match_brief` to create stage-specific semantic briefs, improving roadmap matching accuracy. - Updated path retrieval logic to differentiate between general and stage-specific semantic weights, enhancing exercise relevance. - Added support for anti-patterns and success criteria in stage matching, allowing for more nuanced exercise selection. - Enhanced tests to validate new stage matching features and ensure correct functionality against learning goals. - Incremented application version to reflect these updates.
This commit is contained in:
1 parent
18547613ea
commit
07e147bc76
6 files changed
+591
-81
No files matched your search
@@ -32,13 +32,14 @@ from planning_exercise_retrieval import run_multistage_planning_retrieval
|
||||
from planning_exercise_semantics import (
|
||||
PlanningSemanticBrief,
|
||||
apply_path_retrieval_weights,
|
||||
apply_stage_match_retrieval_weights,
|
||||
brief_to_summary_dict,
|
||||
build_semantic_brief,
|
||||
build_stage_match_brief,
|
||||
enrich_target_with_semantic_expectations,
|
||||
exercise_passes_path_semantic_gate,
|
||||
pick_best_path_hit,
|
||||
resolve_semantic_skill_weights,
|
||||
semantic_brief_for_stage,
|
||||
step_phase_for_index,
|
||||
step_retrieval_query,
|
||||
try_enrich_semantic_brief_with_llm,
|
||||
@@ -185,14 +186,18 @@ def _pick_best_path_hit(
|
||||
*,
|
||||
semantic_brief: Optional[PlanningSemanticBrief] = None,
|
||||
stage_learning_goal: Optional[str] = None,
|
||||
stage_anti_patterns: Optional[List[str]] = None,
|
||||
roadmap_stage_match: bool = False,
|
||||
stage_match_brief: Optional[PlanningSemanticBrief] = None,
|
||||
) -> Optional[Dict[str, Any]]:
|
||||
return pick_best_path_hit(
|
||||
hits,
|
||||
used_exercise_ids,
|
||||
semantic_brief=semantic_brief,
|
||||
stage_learning_goal=stage_learning_goal,
|
||||
stage_anti_patterns=stage_anti_patterns,
|
||||
roadmap_stage_match=roadmap_stage_match,
|
||||
stage_match_brief=stage_match_brief,
|
||||
)
|
||||
|
||||
|
||||
@@ -292,6 +297,11 @@ def _run_path_step_retrieval(
|
||||
step_phase_override: Optional[str] = None,
|
||||
step_target_profile_override: Optional[PlanningTargetProfile] = None,
|
||||
stage_learning_goal: Optional[str] = None,
|
||||
stage_anti_patterns: Optional[List[str]] = None,
|
||||
stage_match_brief: Optional[PlanningSemanticBrief] = None,
|
||||
stage_success_criteria: Optional[List[str]] = None,
|
||||
stage_load_profile: Optional[List[str]] = None,
|
||||
path_context_note: Optional[str] = None,
|
||||
) -> Tuple[List[Dict[str, Any]], PlanningTargetProfile, Dict[str, Any], str]:
|
||||
step_query = step_query_override or step_retrieval_query(
|
||||
semantic_brief, goal_query, step_index, max_steps
|
||||
@@ -328,7 +338,12 @@ def _run_path_step_retrieval(
|
||||
"path_step_phase": step_phase_override
|
||||
or step_phase_for_index(semantic_brief, step_index, max_steps),
|
||||
"stage_learning_goal": (stage_learning_goal or "").strip() or None,
|
||||
"stage_anti_patterns": list(stage_anti_patterns or []),
|
||||
"roadmap_stage_match": bool((stage_learning_goal or "").strip()),
|
||||
"stage_match_brief": stage_match_brief,
|
||||
"stage_success_criteria": list(stage_success_criteria or []),
|
||||
"stage_load_profile": list(stage_load_profile or []),
|
||||
"path_context_note": (path_context_note or "").strip() or None,
|
||||
}
|
||||
pack = apply_progression_context_to_pack(
|
||||
cur,
|
||||
@@ -383,7 +398,10 @@ def _run_path_step_retrieval(
|
||||
has_planning_reference=has_plan_ref,
|
||||
)
|
||||
|
||||
weights = apply_path_retrieval_weights(semantic_brief)
|
||||
if pack.get("roadmap_stage_match"):
|
||||
weights = apply_stage_match_retrieval_weights(semantic_brief)
|
||||
else:
|
||||
weights = apply_path_retrieval_weights(semantic_brief)
|
||||
|
||||
profile_id = tenant.profile_id
|
||||
role = tenant.global_role
|
||||
@@ -490,6 +508,8 @@ def _annotate_roadmap_step(
|
||||
step["roadmap_major_step_index"] = stage_spec.major_step_index
|
||||
step["roadmap_phase"] = major_step.phase if major_step else None
|
||||
step["roadmap_learning_goal"] = learning_goal or None
|
||||
if stage_spec.anti_patterns:
|
||||
step["roadmap_anti_patterns"] = list(stage_spec.anti_patterns)
|
||||
step["roadmap_match_source"] = "stage_spec"
|
||||
if skill_expectations:
|
||||
step["skill_expectations"] = skill_expectations
|
||||
@@ -569,10 +589,22 @@ def _build_steps_roadmap_first(
|
||||
)
|
||||
step_kind = resolve_step_exercise_kind_filter(stage_spec, body.exercise_kind_any)
|
||||
stage_goal = (stage_spec.learning_goal or "").strip()
|
||||
stage_brief = semantic_brief_for_stage(
|
||||
semantic_brief,
|
||||
stage_anti = list(stage_spec.anti_patterns or [])
|
||||
path_context_note = None
|
||||
if rs_dump:
|
||||
ctx_parts = [
|
||||
str(rs_dump.get("start_situation") or "").strip()[:120],
|
||||
str(rs_dump.get("target_state") or "").strip()[:120],
|
||||
str(rs_dump.get("roadmap_notes") or "").strip()[:120],
|
||||
]
|
||||
path_context_note = " ".join(p for p in ctx_parts if p)[:240] or None
|
||||
stage_match_brief = build_stage_match_brief(
|
||||
learning_goal=stage_goal,
|
||||
anti_patterns=stage_anti,
|
||||
success_criteria=list(stage_spec.success_criteria or []),
|
||||
load_profile=list(stage_spec.load_profile or []),
|
||||
phase=major.phase if major else None,
|
||||
path_context_note=path_context_note,
|
||||
)
|
||||
|
||||
hits, _, _, _ = _run_path_step_retrieval(
|
||||
@@ -587,21 +619,28 @@ def _build_steps_roadmap_first(
|
||||
progression_graph_id=body.progression_graph_id,
|
||||
include_llm_intent=body.include_llm_intent and step_index == 0,
|
||||
exercise_kind_any=step_kind,
|
||||
semantic_brief=stage_brief,
|
||||
semantic_brief=stage_match_brief,
|
||||
path_target_profile=path_target_profile,
|
||||
path_intent=path_intent,
|
||||
step_query_override=step_query,
|
||||
step_phase_override=major.phase if major else None,
|
||||
step_target_profile_override=step_target,
|
||||
stage_learning_goal=stage_goal or None,
|
||||
stage_anti_patterns=stage_anti or None,
|
||||
stage_match_brief=stage_match_brief,
|
||||
stage_success_criteria=list(stage_spec.success_criteria or []),
|
||||
stage_load_profile=list(stage_spec.load_profile or []),
|
||||
path_context_note=path_context_note,
|
||||
)
|
||||
|
||||
hit = _pick_best_path_hit(
|
||||
hits,
|
||||
used,
|
||||
semantic_brief=stage_brief,
|
||||
semantic_brief=stage_match_brief,
|
||||
stage_learning_goal=stage_goal or None,
|
||||
stage_anti_patterns=stage_anti or None,
|
||||
roadmap_stage_match=True,
|
||||
stage_match_brief=stage_match_brief,
|
||||
)
|
||||
|
||||
if not hit:
|
||||
|
||||
Reference in new issue
Block a user