fix: CRITICAL - Use question ID (not type) for LLM communication
ROOT ARCHITECTURAL CHANGE:
Multiple questions with same type are now supported!
Problem:
- question_augmenter used q.type as LLM key
- If two questions had type="unsicherheit":
- LLM saw duplicate keys: "- unsicherheit: [ja/nein]"
- Could only answer one
- Signals were ambiguous
Solution:
- Use question.id as LLM key (unique by design)
- Keep type for normalization logic
- Map id → type internally
Backend question_augmenter.py:
- format_question_list() now uses q.id as key
- Format: "- **q21**: [ja/nein] # Question text"
- Question text as comment for LLM context
Backend workflow_executor.py:
- Removed type→id mapping (no longer needed)
- decision_signals now keyed by id (from LLM)
- Build id→type catalog for normalization
- NormalizedSignal.question_type stores id (not type!)
- End Node template: signal_{id} directly available
Flow:
1. Questions sent to LLM: "- q21: [ja/nein] # Ist Protein unsicher?"
2. LLM answers: "- q21: nein"
3. Normalization: id→type lookup for spectrum/rules
4. Template: {{ node_4.signal_q21 }} = "nein"
Example (TWO unsicherheit questions):
Questions:
- q21: type=unsicherheit, question="Ist Protein unsicher?"
- q22: type=unsicherheit, question="Ist Energie unsicher?"
LLM Prompt:
```
## Entscheidungsfragen
- **q21**: [ja/nein] # Ist Protein unsicher?
- **q22**: [ja/nein] # Ist Energie unsicher?
```
LLM Response:
```
- q21: nein
- q22: ja
```
Template:
```
{{ node_4.signal_q21 }} → "nein"
{{ node_4.signal_q22 }} → "ja"
```
BREAKING CHANGE:
- Old workflows with decision_signals keyed by type will break
- Need to re-execute workflows after update
Issue: Cannot have multiple questions with same type
Version: 0.9p (workflow module)
Part 3: End Node Template Engine - ARCHITECTURAL FIX
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
1 parent
29a3dbceb5
commit
de5b8cbf15
2 files changed
+45
-41
No files matched your search
@@ -235,10 +235,13 @@ def format_question_list(questions: List[QuestionAugmentation]) -> str:
|
||||
"""
|
||||
Formatiert Fragenliste als Markdown-Liste.
|
||||
|
||||
Verwendet question.id als Schlüssel (nicht type), damit mehrere Fragen
|
||||
des gleichen Typs möglich sind.
|
||||
|
||||
Format:
|
||||
```
|
||||
- Relevanz: [ja/nein/unklar]
|
||||
- Priorität: [hoch/mittel/niedrig/unklar]
|
||||
- q21: [ja/nein/unklar] # Ist Protein unsicher?
|
||||
- q22: [ja/nein/unklar] # Ist Energie unsicher?
|
||||
```
|
||||
|
||||
Args:
|
||||
@@ -250,7 +253,9 @@ def format_question_list(questions: List[QuestionAugmentation]) -> str:
|
||||
lines = []
|
||||
for q in questions:
|
||||
spectrum_str = "/".join(q.answer_spectrum)
|
||||
lines.append(f"- **{q.type.capitalize()}**: [{spectrum_str}]")
|
||||
# Use ID as key (unique), show question text as comment for context
|
||||
question_text = q.question[:50] if q.question else q.type
|
||||
lines.append(f"- **{q.id}**: [{spectrum_str}] # {question_text}")
|
||||
|
||||
return "\n".join(lines)
|
||||
|
||||
|
||||
Reference in new issue
Block a user