Merge branch 'feature/design-groessen' into develop
Deploy Test / test (push) Successful in 3m9s
Deploy Test / deploy (push) Successful in 35s

This commit is contained in:
Stommer committed 2026-11-22 15:02:22 +01:00
commit aa1e6eb6ac
27 files changed
+1458 -125

No files matched your search

+245
View File
@@ -0,0 +1,245 @@
<?php
namespace Tests\Feature;
use App\Domain\Cms\Page;
use App\Domain\Cms\PageService;
use App\Domain\Design\DesignScale;
use App\Domain\Design\DesignSettings;
use App\Domain\Design\SiteSetting;
use App\Filament\Pages\DesignGroessen;
use App\Filament\Support\WidgetEditor;
use App\Models\User;
use Filament\Facades\Filament;
use Illuminate\Foundation\Testing\RefreshDatabase;
use Illuminate\Support\Facades\Schema;
use Livewire\Livewire;
use Tests\TestCase;
/**
* Größenskala (ADR-44): Speicherung, Wirkung auf Website und Vorschau, Verwaltungsseite, Berechtigung, Ausfallsicherheit.
*/
class DesignScaleSettingsTest extends TestCase
{
use RefreshDatabase;
protected function setUp(): void
{
parent::setUp();
Filament::setCurrentPanel(Filament::getPanel('verwaltung'));
}
private function admin(): User
{
$admin = User::factory()->systemverwalter()->create();
$admin->saveAppAuthenticationSecret('JBSWY3DPEHPK3PXP');
return $admin;
}
private function publishPage(string $path = '/groessen'): void
{
$page = Page::query()->create(['path' => $path]);
$service = app(PageService::class);
$service->publish($page, $service->saveRevision($page, [['type' => 'heading', 'v' => 1, 'data' => ['heading' => 'Größen']]], null, null, null));
}
// ---------------------------------------------------------------------------------------------------------------
// Speicherung
// ---------------------------------------------------------------------------------------------------------------
public function test_without_a_stored_row_the_defaults_apply_and_nothing_is_written(): void
{
$this->assertSame(DesignScale::defaults(), DesignSettings::values());
$this->assertFalse(DesignSettings::isCustomised());
$this->assertSame('', (string) DesignSettings::styleTag());
$this->assertSame(0, SiteSetting::query()->count(), 'Die Migration legt keine Zeile an.');
}
public function test_saving_validates_stores_and_takes_effect_immediately(): void
{
$admin = $this->admin();
$this->assertSame(DesignScale::defaults(), DesignSettings::values());
$errors = DesignSettings::save([...DesignScale::defaults(), 'body' => 18, 'card_pad' => 24], $admin);
$this->assertSame([], $errors);
$this->assertSame(18, DesignSettings::values()['body']);
$this->assertTrue(DesignSettings::isCustomised());
$this->assertSame($admin->getKey(), SiteSetting::query()->find(DesignSettings::KEY)->updated_by);
$this->assertSame('<style id="lf-design-scale">:root{--ds-body:18;--ds-card-pad:24;}</style>', (string) DesignSettings::styleTag());
}
public function test_invalid_input_is_not_stored(): void
{
$errors = DesignSettings::save([...DesignScale::defaults(), 'body' => 40]);
$this->assertArrayHasKey('body', $errors);
$this->assertSame(0, SiteSetting::query()->count());
$this->assertSame(DesignScale::defaults(), DesignSettings::values());
}
public function test_reset_removes_the_row_and_restores_the_defaults(): void
{
DesignSettings::save([...DesignScale::defaults(), 'h1' => 44]);
$this->assertSame(44, DesignSettings::values()['h1']);
DesignSettings::reset();
$this->assertSame(DesignScale::defaults(), DesignSettings::values());
$this->assertSame(0, SiteSetting::query()->count());
$this->assertSame('', (string) DesignSettings::styleTag());
}
public function test_damaged_stored_data_falls_back_to_the_defaults(): void
{
SiteSetting::query()->create(['key' => DesignSettings::KEY, 'value' => ['body' => 999, 'h1' => 'x']]);
DesignSettings::flush();
$this->assertSame(DesignScale::defaults(), DesignSettings::values());
$this->assertSame('', (string) DesignSettings::styleTag());
}
public function test_a_missing_table_does_not_break_the_public_site(): void
{
$this->publishPage();
Schema::drop('site_settings');
DesignSettings::flush();
$this->get('/groessen')->assertOk()->assertSee('Größen')->assertDontSee('lf-design-scale', false);
$this->assertSame(DesignScale::defaults(), DesignSettings::values());
}
// ---------------------------------------------------------------------------------------------------------------
// Wirkung auf Website, Anmeldung, Mitgliederbereich und Vorschau
// ---------------------------------------------------------------------------------------------------------------
public function test_the_public_site_the_login_and_the_member_area_use_the_stored_values_after_the_stylesheet(): void
{
$this->publishPage();
DesignSettings::save([...DesignScale::defaults(), 'body' => 19, 'header' => 96]);
foreach (['/groessen', '/anmelden'] as $path) {
$html = $this->get($path)->assertOk()->getContent();
$this->assertStringContainsString('<style id="lf-design-scale">:root{--ds-body:19;--ds-header:96;}</style>', $html, $path);
}
$member = User::factory()->create();
$html = $this->actingAs($member)->get(route('member.dashboard'))->getContent();
$this->assertStringContainsString('--ds-body:19;', $html, 'Der Mitgliederbereich nutzt dieselbe Skala.');
}
public function test_defaults_add_no_inline_block_to_the_page(): void
{
$this->publishPage();
$this->get('/groessen')->assertOk()->assertDontSee('lf-design-scale', false);
}
public function test_the_cms_previews_use_the_same_active_values(): void
{
$this->assertStringNotContainsString('lf-design-scale', WidgetEditor::previewStylesheets());
DesignSettings::save([...DesignScale::defaults(), 'h2' => 30, 'media' => 360]);
$this->assertStringContainsString(':root{--ds-h2:30;--ds-media:360;}', WidgetEditor::previewStylesheets());
}
// ---------------------------------------------------------------------------------------------------------------
// Verwaltungsseite
// ---------------------------------------------------------------------------------------------------------------
public function test_only_the_system_administrator_may_open_the_page(): void
{
$editor = User::factory()->redakteur()->create();
$editor->saveAppAuthenticationSecret('JBSWY3DPEHPK3PXP');
$this->get('/verwaltung/design/groessen')->assertRedirect();
$this->actingAs($editor, 'staff')->get('/verwaltung/design/groessen')->assertForbidden();
$this->actingAs($this->admin(), 'staff')->get('/verwaltung/design/groessen')->assertOk()->assertSee('Größen')->assertSee('Fließtext');
}
public function test_the_page_is_listed_in_the_navigation_for_the_administrator(): void
{
$this->actingAs($this->admin(), 'staff')->get('/verwaltung/design/groessen')->assertOk()
->assertSee('Design')
->assertSee(DesignGroessen::getUrl());
}
public function test_the_form_shows_the_active_values_and_saves_changes_with_one_action(): void
{
$component = Livewire::actingAs($this->admin(), 'staff')->test(DesignGroessen::class);
$component->assertSet('werte.body', 17)->assertSet('werte.width', 1312);
$this->assertFalse($component->instance()->geaendert());
$component->set('werte.body', '18')->set('werte.media', '300');
$this->assertTrue($component->instance()->geaendert());
$this->assertSame(DesignScale::defaults(), DesignSettings::values(), 'Offene Eingaben speichern nichts.');
$component->call('speichern')->assertHasNoErrors();
$this->assertSame(18, DesignSettings::values()['body']);
$this->assertSame(300, DesignSettings::values()['media']);
$this->assertFalse($component->instance()->geaendert());
}
public function test_invalid_values_show_messages_and_are_not_saved(): void
{
$component = Livewire::actingAs($this->admin(), 'staff')->test(DesignGroessen::class)
->set('werte.body', '99')
->set('werte.h2', '')
->call('speichern');
$this->assertArrayHasKey('body', $component->get('fehler'));
$this->assertArrayHasKey('h2', $component->get('fehler'));
$this->assertSame(0, SiteSetting::query()->count());
$component->assertSee('mindestens 16 px', false)->assertSee('höchstens 20 px', false);
}
public function test_restoring_the_defaults_needs_a_confirmation_and_clears_the_stored_values(): void
{
DesignSettings::save([...DesignScale::defaults(), 'body' => 18, 'section' => 64]);
$component = Livewire::actingAs($this->admin(), 'staff')->test(DesignGroessen::class)
->assertSet('werte.section', 64)
->call('askConfirmation', 'standard');
$this->assertSame(64, DesignSettings::values()['section'], 'Erst die Bestätigung wirkt.');
$component->assertSee('Standardwerte wiederherstellen?', false)->call('confirmConfirmation');
$this->assertSame(DesignScale::defaults(), DesignSettings::values());
$component->assertSet('werte.section', 48)->assertSet('bestaetigung', null);
}
public function test_cancelling_the_confirmation_keeps_everything(): void
{
DesignSettings::save([...DesignScale::defaults(), 'body' => 18]);
Livewire::actingAs($this->admin(), 'staff')->test(DesignGroessen::class)
->call('askConfirmation', 'standard')
->call('cancelConfirmation')
->assertSet('bestaetigung', null);
$this->assertSame(18, DesignSettings::values()['body']);
}
public function test_discarding_returns_the_inputs_to_the_active_state_without_saving(): void
{
$component = Livewire::actingAs($this->admin(), 'staff')->test(DesignGroessen::class)
->set('werte.h1', '44')
->call('askConfirmation', 'verwerfen')
->call('confirmConfirmation')
->assertSet('werte.h1', 40);
$this->assertSame(0, SiteSetting::query()->count());
$this->assertFalse($component->instance()->geaendert());
}
public function test_a_redakteur_cannot_call_the_page_component(): void
{
$editor = User::factory()->redakteur()->create();
Livewire::actingAs($editor, 'staff')->test(DesignGroessen::class)->assertForbidden();
}
}
+2
View File
@@ -2,6 +2,7 @@
namespace Tests;
use App\Domain\Design\DesignSettings;
use Illuminate\Foundation\Testing\TestCase as BaseTestCase;
abstract class TestCase extends BaseTestCase
@@ -11,5 +12,6 @@ protected function setUp(): void
parent::setUp();
$this->withoutVite();
DesignSettings::flush();
}
}
+95
View File
@@ -0,0 +1,95 @@
<?php
namespace Tests\Unit;
use App\Domain\Design\DesignScale;
use Tests\TestCase;
/**
* Größenskala (ADR-44): Standardwerte, Wertebereiche, Reihenfolge der Schriftgrößen und die ausgegebenen Variablen.
*/
class DesignScaleTest extends TestCase
{
public function test_the_defaults_are_the_agreed_initial_values(): void
{
$this->assertSame([
'body' => 17, 'h1' => 40, 'h2' => 28, 'display' => 52, 'space' => 8,
'section' => 48, 'card_pad' => 20, 'header' => 80, 'width' => 1312, 'media' => 320,
], DesignScale::defaults());
$this->assertSame([], DesignScale::errors(DesignScale::defaults()));
}
public function test_every_default_lies_within_its_range(): void
{
foreach (DesignScale::PARAMETERS as $key => $p) {
$this->assertGreaterThanOrEqual($p['min'], $p['default'], $key);
$this->assertLessThanOrEqual($p['max'], $p['default'], $key);
$this->assertContains($p['group'], DesignScale::GROUPS, $key);
}
}
public function test_the_defaults_equal_the_values_in_the_stylesheet(): void
{
$css = file_get_contents(dirname(__DIR__, 2).'/resources/css/tokens.css');
$this->assertNotFalse($css);
preg_match_all('/--ds-([a-z0-9-]+):\s*(\d+);/', $css, $found, PREG_SET_ORDER);
$declared = [];
foreach ($found as [, $name, $value]) {
$declared[str_replace('-', '_', $name)] = (int) $value;
}
$this->assertSame(DesignScale::defaults(), $declared, 'tokens.css (Block Größenskala) und DesignScale::PARAMETERS müssen dieselben Standardwerte haben.');
}
public function test_values_outside_the_ranges_are_rejected_with_a_message_per_field(): void
{
$errors = DesignScale::errors([...DesignScale::defaults(), 'body' => 12, 'width' => 3000, 'media' => 'abc', 'space' => '']);
$this->assertEqualsCanonicalizing(['body', 'width', 'media', 'space'], array_keys($errors));
$this->assertStringContainsString('mindestens 16 px', $errors['body']);
$this->assertStringContainsString('höchstens 1600 px', $errors['width']);
$this->assertStringContainsString('ganze Zahl', $errors['media']);
$this->assertStringContainsString('Bitte einen Wert', $errors['space']);
}
public function test_the_order_of_the_type_sizes_is_enforced(): void
{
$this->assertArrayHasKey('h2', DesignScale::errors([...DesignScale::defaults(), 'body' => 20, 'h2' => 24]));
$this->assertArrayHasKey('h1', DesignScale::errors([...DesignScale::defaults(), 'h2' => 36, 'h1' => 38]));
$this->assertArrayHasKey('display', DesignScale::errors([...DesignScale::defaults(), 'h1' => 50, 'display' => 44]));
$this->assertSame([], DesignScale::errors([...DesignScale::defaults(), 'body' => 18, 'h2' => 24, 'h1' => 30, 'display' => 36]));
}
public function test_form_strings_are_accepted_as_numbers(): void
{
$input = array_map('strval', DesignScale::defaults());
$this->assertSame([], DesignScale::errors($input));
$this->assertSame([], DesignScale::errors([...$input, 'body' => '18']));
$this->assertNotSame([], DesignScale::errors([...$input, 'body' => '17.5']), 'Nur ganze Pixel.');
}
public function test_only_deviating_values_become_variables(): void
{
$this->assertSame('', DesignScale::css(DesignScale::defaults()));
$this->assertSame(':root{--ds-body:18;--ds-card-pad:24;}', DesignScale::css([...DesignScale::defaults(), 'body' => 18, 'card_pad' => 24]));
}
public function test_the_stylesheet_block_contains_only_validated_numbers_of_known_keys(): void
{
$css = DesignScale::css([...DesignScale::defaults(), 'body' => 18, 'evil' => '};body{display:none}', 'h1' => 99999]);
$this->assertSame(':root{--ds-body:18;}', $css, 'Unbekannte Schlüssel und Werte außerhalb des Bereichs werden nie ausgegeben.');
}
public function test_reading_stored_values_never_fails_and_falls_back_to_the_defaults(): void
{
$this->assertSame(DesignScale::defaults(), DesignScale::read(null));
$this->assertSame(DesignScale::defaults(), DesignScale::read('kaputt'));
$this->assertSame(DesignScale::defaults(), DesignScale::read(['body' => 99]), 'Außerhalb des Bereichs: Standard.');
$this->assertSame(DesignScale::defaults(), DesignScale::read(['h1' => 30, 'h2' => 29]), 'Falsche Reihenfolge: Standard.');
$this->assertSame([...DesignScale::defaults(), 'body' => 18], DesignScale::read(['body' => 18, 'unbekannt' => 5, 'h1' => 'x']), 'Fehlendes und Fremdes wird ignoriert.');
$this->assertSame([...DesignScale::defaults(), 'body' => 18], DesignScale::read(['body' => '18']));
}
}