Apply learned mask reviews by local cue and highlight the reviewed mention.
Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
1 parent
3f7c0d71a5
commit
f7ffd28332
10 files changed
+413
-36
No files matched your search
@@ -16,7 +16,13 @@ os.environ["KANSHO_FAKE_PROVIDER"] = "1"
|
||||
os.environ["KANSHO_FAKE_DETECT"] = "1"
|
||||
|
||||
from fastapi.testclient import TestClient
|
||||
from detect_learning import get_detect_operating_mode, get_sense, record_sense
|
||||
from detect_learning import (
|
||||
excerpt_view,
|
||||
get_cue_decision,
|
||||
get_detect_operating_mode,
|
||||
get_sense,
|
||||
record_sense,
|
||||
)
|
||||
from dialogue_turn import visible_for_role
|
||||
from identity_store import list_confirmed_identities
|
||||
from main import app
|
||||
@@ -161,6 +167,13 @@ def main() -> None:
|
||||
status_ok(declined, "not_identity review")
|
||||
expect(not any((item.get("canonical_label") or "").casefold() == "hanna" for item in list_confirmed_identities(profile_id)), "not_identity does not confirm Hanna")
|
||||
expect(get_sense(profile_id, "Hanna")["non_identity_hits"] >= 1, "not_identity records a sense")
|
||||
hanna_again = client.post(
|
||||
f"/api/journal/conversations/{food_conv}/turn",
|
||||
headers=headers,
|
||||
json={"body": "Hanna aß mit uns."},
|
||||
)
|
||||
status_ok(hanna_again, "second Hanna turn")
|
||||
expect(not hanna_again.json().get("pending_mask_review"), "known non-identity skips the popup")
|
||||
|
||||
record_sense(profile_id, "Clarissa", identity=True)
|
||||
record_sense(profile_id, "Clarissa", identity=False)
|
||||
@@ -180,12 +193,30 @@ def main() -> None:
|
||||
kin = client.post(
|
||||
f"/api/journal/conversations/{kin_conv}/turn",
|
||||
headers=headers,
|
||||
json={"body": "Ich war mit meinem Sohn Rohan im Park."},
|
||||
json={"body": "Ich war mit meinem Sohn Leon im Park."},
|
||||
)
|
||||
status_ok(kin, "kinship Rohan pause")
|
||||
status_ok(kin, "kinship Leon pause")
|
||||
kin_review = kin.json().get("pending_mask_review") or {}
|
||||
kin_names = [item.get("text") for item in kin_review.get("candidates") or []]
|
||||
expect("Rohan" in kin_names, "Sohn Rohan is offered even when Detect does not report it")
|
||||
expect("Leon" in kin_names, "Sohn Leon is offered even when Detect does not report it")
|
||||
leon = next((item for item in kin_review.get("candidates") or [] if item.get("text") == "Leon"), None)
|
||||
expect(leon is not None, "Leon candidate id is present")
|
||||
kin_done = client.post(
|
||||
f"/api/journal/conversations/{kin_conv}/turn/review",
|
||||
headers=headers,
|
||||
json={
|
||||
"review_id": kin_review["id"],
|
||||
"decisions": [{"id": leon["id"], "decision": "identity"}],
|
||||
},
|
||||
)
|
||||
status_ok(kin_done, "Leon identity review")
|
||||
kin_again = client.post(
|
||||
f"/api/journal/conversations/{kin_conv}/turn",
|
||||
headers=headers,
|
||||
json={"body": "Ich war mit meinem Sohn Leon im Park."},
|
||||
)
|
||||
status_ok(kin_again, "second Leon turn")
|
||||
expect(not kin_again.json().get("pending_mask_review"), "confirmed Sohn Leon skips the popup")
|
||||
|
||||
sushi_conv = open_conv(client, headers)
|
||||
sushi = client.post(
|
||||
@@ -203,6 +234,73 @@ def main() -> None:
|
||||
expect("Rohan" in sushi_names, "Rohan from Sohn is a candidate")
|
||||
expect("Sushi" in sushi_names, "Sushi from Frau is a candidate")
|
||||
expect("Restaurant" not in sushi_names, "plain Restaurant is not kinship-offered")
|
||||
sushi_hits = [
|
||||
item
|
||||
for item in (sushi.json().get("pending_mask_review") or {}).get("candidates") or []
|
||||
if item.get("text") == "Sushi"
|
||||
]
|
||||
expect(len(sushi_hits) >= 2, "both Sushi mentions are offered")
|
||||
expect(
|
||||
sushi_hits[0].get("highlight_start") != sushi_hits[1].get("highlight_start"),
|
||||
"the two Sushi mentions highlight different offsets",
|
||||
)
|
||||
for item in sushi_hits:
|
||||
excerpt = item.get("excerpt") or ""
|
||||
start = item.get("highlight_start")
|
||||
end = item.get("highlight_end")
|
||||
expect(excerpt[start:end] == "Sushi", "highlight covers the Sushi token")
|
||||
|
||||
homonym = (
|
||||
"Gestern bin ich mit meiner Frau Sushi und meinem Sohn Rohan "
|
||||
"Sushi essen gegangen."
|
||||
)
|
||||
first_at = homonym.index("Sushi")
|
||||
second_at = homonym.rindex("Sushi")
|
||||
first = excerpt_view(homonym, first_at, first_at + 5, "Sushi")
|
||||
second = excerpt_view(homonym, second_at, second_at + 5, "Sushi")
|
||||
expect(first["highlight_start"] < second["highlight_start"], "person Sushi sits left of dish Sushi")
|
||||
expect(first["excerpt"][first["highlight_start"]:first["highlight_end"]] == "Sushi", "first highlight is Sushi")
|
||||
expect(second["excerpt"][second["highlight_start"]:second["highlight_end"]] == "Sushi", "second highlight is Sushi")
|
||||
prefix = "SYSTEM\n"
|
||||
mapped = excerpt_view(
|
||||
homonym,
|
||||
len(prefix) + second_at,
|
||||
len(prefix) + second_at + 5,
|
||||
"Sushi",
|
||||
prefix + homonym,
|
||||
)
|
||||
expect(mapped["highlight_start"] == second["highlight_start"], "rendered detect offsets map to the dish Sushi")
|
||||
|
||||
sushi_review = sushi.json().get("pending_mask_review") or {}
|
||||
sushi_decisions = []
|
||||
for item in sushi_review.get("candidates") or []:
|
||||
label = item.get("text")
|
||||
cue = item.get("cue")
|
||||
if label == "Sushi" and cue != "frau":
|
||||
sushi_decisions.append({"id": item["id"], "decision": "not_identity"})
|
||||
else:
|
||||
sushi_decisions.append({"id": item["id"], "decision": "identity"})
|
||||
sushi_done = client.post(
|
||||
f"/api/journal/conversations/{sushi_conv}/turn/review",
|
||||
headers=headers,
|
||||
json={"review_id": sushi_review["id"], "decisions": sushi_decisions},
|
||||
)
|
||||
status_ok(sushi_done, "homonym review")
|
||||
expect(get_cue_decision(profile_id, "Sushi", "frau") == "identity", "Frau Sushi is stored as identity")
|
||||
expect(get_cue_decision(profile_id, "Sushi", "rohan") == "not_identity", "dish Sushi after Rohan is stored")
|
||||
expect(get_cue_decision(profile_id, "Rohan", "sohn") == "identity", "Sohn Rohan cue is stored")
|
||||
sushi_again = client.post(
|
||||
f"/api/journal/conversations/{sushi_conv}/turn",
|
||||
headers=headers,
|
||||
json={
|
||||
"body": (
|
||||
"Gestern bin ich mit meiner Frau Sushi und meinem Sohn Rohan "
|
||||
"Sushi essen gegangen. Das Restaurant hat mich dabei total beeindruckt."
|
||||
)
|
||||
},
|
||||
)
|
||||
status_ok(sushi_again, "repeat homonym sentence")
|
||||
expect(not sushi_again.json().get("pending_mask_review"), "same reviewed sentence does not re-ask")
|
||||
|
||||
back = client.put("/api/admin/providers/detect-mode", headers=headers, json={"mode": "semantic"})
|
||||
expect(back.json()["detect_operating_mode"] == "semantic", "mode can return to semantic")
|
||||
|
||||
Reference in new issue
Block a user