Keep journal openings from treating finished days as open plans.
A 400-character entry prefix plus plan regex could reopen a completed yesterday as if it were still pending. Openings now take plans only from yesterday's user dialogue, never from saved entries, and skip space recency in the first call. Co-authored-by: Cursor <cursoragent@cursor.com>
This commit is contained in:
1 parent
e42f751fdc
commit
ec0f8bad55
8 files changed
+108
-19
No files matched your search
@@ -6,6 +6,8 @@ import sys
|
||||
import tempfile
|
||||
from pathlib import Path
|
||||
|
||||
from datetime import date
|
||||
|
||||
ROOT = Path(__file__).resolve().parents[1]
|
||||
sys.path.insert(0, str(ROOT))
|
||||
|
||||
@@ -23,6 +25,8 @@ from journal_opening import (
|
||||
attested_plans_from_user_texts,
|
||||
collect_opening_context,
|
||||
is_attested_plan,
|
||||
is_previous_calendar_day,
|
||||
parse_calendar_date,
|
||||
)
|
||||
from journal_reconstruct import assign_source_ids
|
||||
from retrieval import pair_user_priority_messages
|
||||
@@ -58,6 +62,9 @@ def main() -> None:
|
||||
expect(not is_attested_plan("Heute war der Hafen ruhig. Kirschen am Stand."), "past report is not a plan")
|
||||
expect(not is_attested_plan("Wir standen vor dem Hafen und aßen Kirschen."), "vor without haben is not a plan")
|
||||
expect(not is_attested_plan("Hafen Kirschen Wind"), "word overlap is not a plan")
|
||||
expect(parse_calendar_date("2026-08-29") == date(2026, 8, 29), "calendar date parses")
|
||||
expect(is_previous_calendar_day(date(2026, 8, 29), date(2026, 8, 30)), "yesterday is previous")
|
||||
expect(not is_previous_calendar_day(date(2026, 8, 29), date(2026, 9, 3)), "older than yesterday is not previous")
|
||||
plans = attested_plans_from_user_texts(
|
||||
["Heute war der Hafen ruhig.", "Morgen wollen wir nach Cres fahren.", "Hafen Kirschen"]
|
||||
)
|
||||
@@ -157,6 +164,48 @@ def main() -> None:
|
||||
expect(overlap_open.json().get("opening", {}).get("kind") == "local_neutral", "overlap falls back to neutral")
|
||||
expect("Muster" not in (overlap_open.json().get("opening") or {}).get("assistant", {}).get("body", ""), "neutral impulse does not claim a pattern")
|
||||
|
||||
done_space, done_day = open_space_day(client, headers, "Abgeschlossen", "2026-08-20")
|
||||
done_conv = start_conv(client, headers, done_day["day"]["id"])
|
||||
client.post(
|
||||
f"/api/journal/conversations/{done_conv.json()['id']}/turn",
|
||||
headers=headers,
|
||||
json={"body": "Nachmittag am Strand, abends Eis, dann schlafen."},
|
||||
)
|
||||
client.post(
|
||||
"/api/journal/entries",
|
||||
headers=headers,
|
||||
json={
|
||||
"journal_day_id": done_day["day"]["id"],
|
||||
"title": "Hitze",
|
||||
"body": (
|
||||
"Schon um 6 Uhr schlug mir eine drückende Luft entgegen. "
|
||||
"Ich hatte überlegt, die Roller auf den nächsten Tag zu schieben. "
|
||||
"Wir haben sie dann doch geholt und sind den Tag gefahren."
|
||||
),
|
||||
"origin": "user_edit",
|
||||
},
|
||||
)
|
||||
later_done = client.post(
|
||||
f"/api/journal/spaces/{done_space['id']}/days",
|
||||
headers=headers,
|
||||
json={"calendar_date": "2026-08-21"},
|
||||
)
|
||||
done_open = start_conv(client, headers, later_done.json()["day"]["id"])
|
||||
done_facts = collect_opening_context(setup.json()["profile_id"], done_open.json()["id"])
|
||||
expect(not done_facts["attested_plans"], "completed journal entry is not an opening plan")
|
||||
expect(not done_facts["has_relevant_context"], "a closed earlier day does not keep the next opening relevant")
|
||||
expect(done_open.json().get("opening", {}).get("kind") == "local_neutral", "completed story falls back to neutral")
|
||||
|
||||
stale = client.post(
|
||||
f"/api/journal/spaces/{plan_space['id']}/days",
|
||||
headers=headers,
|
||||
json={"calendar_date": "2026-08-04"},
|
||||
)
|
||||
stale_open = start_conv(client, headers, stale.json()["day"]["id"])
|
||||
stale_facts = collect_opening_context(setup.json()["profile_id"], stale_open.json()["id"])
|
||||
expect(not any("Cres" in item for item in stale_facts["attested_plans"]), "plan from two days ago is no longer an opening mandate")
|
||||
expect(stale_open.json().get("opening", {}).get("kind") == "local_neutral", "stale plan uses local neutral")
|
||||
|
||||
asst_space, asst_day = open_space_day(client, headers, "Assistent", "2026-08-05")
|
||||
asst_conv = start_conv(client, headers, asst_day["day"]["id"])
|
||||
from dialogue_store import append_message
|
||||
|
||||
Reference in new issue
Block a user